Skip to content

fix(power): backport Power Button page collision fix to 7.3 - #2729

Merged
tom mortensen (limetech) merged 1 commit into
7.3from
fix/os-737-backport-power-button-tab-7-3-3
Aug 21, 2026
Merged

fix(power): backport Power Button page collision fix to 7.3#2729
tom mortensen (limetech) merged 1 commit into
7.3from
fix/os-737-backport-power-button-tab-7-3-3

Conversation

@elibosley

@elibosley Eli Bosley (elibosley) commented Aug 18, 2026

Copy link
Copy Markdown
Member

Summary

Backport the Power Options page-name collision fix to the Unraid 7.3.3 line on top of the reviewed 7.3 Power Button implementation.

Why This Exists

The built-in Power Button page uses the same filename stem as the Dynamix System Buttons plugin. PageBuilder keys pages by basename, so the plugin can replace the built-in Power Button tab.

This is the 7.3.3 follow-up to DST-200. It depends on the configurable Power Button backport tracked by OS-644 and PR #2715.

Resolution

Rename the built-in PowerButton.page to PowerModeButton.page. The page content, visible title, and tab position remain unchanged.

Reviewer Considerations

Behavior Changes

With Dynamix System Buttons installed, Settings > Power Options keeps both the Power Mode and Power Button tabs.

Implementation Summary

Verification

  • git diff --check
  • Confirmed Menu="PowerMode:2" and Title="Power Button" remain unchanged.

Risk

Low. The page content is unchanged. Only the page basename changes.

Linear Cross-links

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3276449c-790f-471b-b29b-7ba229f605e2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@elibosley
Eli Bosley (elibosley) marked this pull request as ready for review August 18, 2026 21:06
@github-actions

Copy link
Copy Markdown

🔧 PR Test Plugin Available

A test plugin has been generated for this PR that includes the modified files.

Version: 2026.08.18.2106
Build: View Workflow Run

📥 Installation Instructions:

Install via Unraid Web UI:

  1. Go to Plugins → Install Plugin
  2. Copy and paste this URL:
https://preview.dl.unraid.net/pr-plugins/pr-2729/webgui-pr-2729.plg
  1. Click Install

Alternative: Direct Download

⚠️ Important Notes:

  • Testing only: This plugin is for testing PR changes
  • Backup included: Original files are automatically backed up
  • Easy removal: Files are restored when plugin is removed
  • Conflicts: Remove this plugin before installing production updates
  • Post-merge behavior: This preview stays available after merge until preview storage expires or it is manually cleaned up

📝 Modified Files:

Click to expand file list
emhttp/plugins/dynamix/PowerModeButton.page

🔄 To Remove:

Navigate to Plugins → Installed Plugins and remove webgui-pr-2729, or run:

plugin remove webgui-pr-2729

🤖 This comment is automatically generated and will be updated with each new push to this PR.

@unraid-bot Unraid Bot (unraid-bot) added 7.4.0 Approved for release 7.4.0 (auto-managed by notification-worker) 7.3.3 Approved for release 7.3.3 (auto-managed by notification-worker) and removed 7.4.0 Approved for release 7.4.0 (auto-managed by notification-worker) 7.3.3 Approved for release 7.3.3 (auto-managed by notification-worker) labels Aug 18, 2026
@elibosley Eli Bosley (elibosley) added the 7.3.3 Approved for release 7.3.3 (auto-managed by notification-worker) label Aug 20, 2026
@limetech
tom mortensen (limetech) merged commit 7ed5639 into 7.3 Aug 21, 2026
5 checks passed
@limetech
tom mortensen (limetech) deleted the fix/os-737-backport-power-button-tab-7-3-3 branch August 21, 2026 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

7.3.3 Approved for release 7.3.3 (auto-managed by notification-worker) Needs Build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants