Skip to content

Implemented capabilities API on VFS#2792

Merged
DavyLandman merged 4 commits into
mainfrom
feat/vfs-capabilities
Jun 4, 2026
Merged

Implemented capabilities API on VFS#2792
DavyLandman merged 4 commits into
mainfrom
feat/vfs-capabilities

Conversation

@DavyLandman
Copy link
Copy Markdown
Member

This API adds a capability feature to the remote VFS feature that was added in #2641

It allows servers to communicate that some parts of the VFS are not or partially supported.

@DavyLandman DavyLandman requested a review from rodinaarssen June 3, 2026 08:58
Copy link
Copy Markdown
Member

@rodinaarssen rodinaarssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, this is a very valuable addition to the remote resolver registries.

Looks good overall, just some remarks here and there

Comment thread src/org/rascalmpl/uri/remote/jsonrpc/CapabilitiesResponse.java
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/CapabilitiesResponse.java
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/CapabilitiesResponse.java Outdated
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/Capability.java Outdated
Comment thread src/org/rascalmpl/uri/IExternalResolverRegistry.java
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/CapabilityLevel.java Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2026

Codecov Report

❌ Patch coverage is 0% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (c912f8b) to head (a3b816f).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...mpl/uri/remote/RemoteExternalResolverRegistry.java 0% 41 Missing ⚠️
...c/org/rascalmpl/uri/remote/jsonrpc/Capability.java 0% 21 Missing ⚠️
...almpl/uri/remote/jsonrpc/CapabilitiesResponse.java 0% 20 Missing ⚠️
src/org/rascalmpl/uri/URIResolverRegistry.java 0% 8 Missing and 4 partials ⚠️
.../rascalmpl/uri/remote/jsonrpc/CapabilityLevel.java 0% 12 Missing ⚠️
...rascalmpl/uri/remote/RascalFileSystemServices.java 0% 5 Missing ⚠️
src/org/rascalmpl/uri/watch/WatchRegistry.java 0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##              main   #2792    +/-   ##
========================================
- Coverage       46%     46%    -1%     
+ Complexity    6720    6719     -1     
========================================
  Files          829     832     +3     
  Lines        66583   66689   +106     
  Branches      9955    9975    +20     
========================================
- Hits         30778   30773     -5     
- Misses       33420   33531   +111     
  Partials      2385    2385            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/org/rascalmpl/uri/remote/jsonrpc/Capability.java
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/Capability.java
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/CapabilitiesResponse.java
Comment thread src/org/rascalmpl/uri/remote/jsonrpc/Capability.java Outdated
Comment thread src/org/rascalmpl/uri/remote/RemoteExternalResolverRegistry.java Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 3, 2026

@DavyLandman DavyLandman merged commit 4c12581 into main Jun 4, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants