Skip to content

added see related events logexplorer filters#2320

Open
AlexSanchez-bit wants to merge 2 commits into
release/v12.0.0from
backlog/v12_seeevents_logexplorer
Open

added see related events logexplorer filters#2320
AlexSanchez-bit wants to merge 2 commits into
release/v12.0.0from
backlog/v12_seeevents_logexplorer

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

⚠️ architecture (gemini-3-flash-lite) — non-blocking warnings

Summary: Logic for index pattern normalization added to usecase layer; frontend deep-linking logic updated.

  • medium backend/modules/opensearch/usecase/index_pattern.go:52 — Business logic for index pattern normalization (prefixing/formatting) is implemented directly in the usecase. Consider moving this to a domain service or a dedicated helper function to ensure consistency across all index creation paths.

🛑 bugs (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Mutation of request object in opensearch usecase causes side effects and potential data inconsistency.

  • high backend/modules/opensearch/usecase/index_pattern.go:53 — The code modifies the 'req' pointer directly. Since 'req' is passed by value in the signature but is a pointer to a struct, this mutation affects the caller's state, which is unexpected and can lead to side effects if the request object is reused or logged after this call.
  • medium frontend/src/features/log-explorer/pages/LogExplorerPage.tsx:16 — The comment 'Deep-link seed: any query param becomes a filter' is misleading because the code explicitly ignores the '@timestamp' field as a filter, treating it as a range preset instead.

🛑 security (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Potential OpenSearch index injection and improper URL parameter handling in LogExplorer

  • high backend/modules/opensearch/usecase/index_pattern.go:52 — Potential OpenSearch index pattern injection. The 'normalized' variable is constructed from user-controlled input without sufficient validation, allowing for path traversal or wildcard injection into the index pattern string.
  • medium frontend/src/features/log-explorer/pages/LogExplorerPage.tsx:25 — Reflected XSS risk via URL parameters. The code iterates over URLSearchParams and uses the 'field' key directly in the 'filters' object, which is later rendered in the UI without sanitization.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant