Skip to content

fix[frontend](parsing_filters): added add entries params on filter form#2327

Open
AlexSanchez-bit wants to merge 3 commits into
release/v12.0.0from
backlog/v12_parsing_filters
Open

fix[frontend](parsing_filters): added add entries params on filter form#2327
AlexSanchez-bit wants to merge 3 commits into
release/v12.0.0from
backlog/v12_parsing_filters

Conversation

@AlexSanchez-bit

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown

🛑 AI review — Engineer review required

This PR touches critical paths or introduces changes the model cannot judge with sufficient confidence. @Kbayero @osmontero please review.

🛑 architecture (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Breaking change to the 'add' parsing filter schema (params changed from array to object), requiring backend/agent compatibility check.

  • high frontend/src/features/parsing-filters/lib/filter-model.ts:140 — The 'add' filter configuration schema has been changed from 'params: []' (array) to 'params: {}' (object). This is a breaking change for the backend and any agents processing these filters; ensure the ingestion pipeline and agent-side parsing logic are updated to handle this new structure.

🛑 bugs (gemini-3-flash-lite) — blocking — must fix before merge

Summary: Type mismatch in 'add' filter configuration breaks existing logic and UI expectations.

  • high frontend/src/features/parsing-filters/lib/filter-model.ts:141 — The 'add' filter configuration 'params' field is changed from an array to an object. This is a breaking change for existing 'add' filters that expect an array, likely causing runtime errors in downstream processing or serialization.
  • critical frontend/src/features/parsing-filters/components/VisualFilterEditor.tsx:290 — The 'list' helper function expects an array, but the 'add' filter now initializes 'params' as an object. Accessing 'params' via 'list' in other parts of the application will now return an empty array instead of the actual data, leading to data loss or UI bugs.

⚠️ security (gemini-3-flash-lite) — non-blocking warnings

Summary: Missing input validation for 'params' object in VisualFilterEditor allows arbitrary key-value injection into filter configurations.

  • medium frontend/src/features/parsing-filters/components/VisualFilterEditor.tsx:351 — The 'params' configuration object is updated via uncontrolled user input in TextField components without validation or sanitization. This could lead to injection of unexpected keys into the filter configuration, potentially causing downstream processing errors or logic bypasses. Implement schema validation for the 'params' object.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

@utmstackprapprover utmstackprapprover Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes requested — AI review found blocking issues (high/critical, or engineer review required). See above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v12 - The parsing-filter view does not show the corresponding parameters for the add step.

1 participant