Skip to content

fix(bitbucket): report that the archive url carries no credential #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 2 commits into from
Aug 7, 2026
Merged

fix(bitbucket): report that the archive url carries no credential #129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0ad656
feat: report whether an archive url carries its own credential
HarshMN2345 Aug 7, 2026
d173c01
style(vcs): keep the archive note to the fact that matters
HarshMN2345 Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/VCS/Adapter/Git.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,12 @@ abstract public function createWebhook(string $owner, string $repositoryName, st
*/
abstract public function createTag(string $owner, string $repositoryName, string $tagName, string $target, string $message = ''): array;

/** Whether the archive url reaches a private repository on its own. */
public function supportsAuthenticatedArchiveUrl(): bool
{
return true;
}

/**
* Get a short-lived URL to download the repository archive.
*
Expand Down
9 changes: 9 additions & 0 deletions src/VCS/Adapter/Git/Bitbucket.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1413,6 +1413,15 @@ private function authenticatedBitbucketUrl(): string
return str_replace('://', '://' . $userinfo . '@', $this->bitbucketUrl);
}

/**
* The archive host answers a token in the url with a redirect to a login
* page. The git endpoint accepts the same token.
*/
public function supportsAuthenticatedArchiveUrl(): bool
{
return false;
}

/**
* @link https://support.atlassian.com/bitbucket-cloud/kb/how-to-download-repositories-using-the-api/
*
Expand Down
Loading