fix(bitbucket): name a project when the workspace won't pick one - #131
Closed
HarshMN2345 wants to merge 10 commits into
Closed
fix(bitbucket): name a project when the workspace won't pick one#131HarshMN2345 wants to merge 10 commits into
HarshMN2345 wants to merge 10 commits into
Conversation
A Bitbucket repository belongs to a project. Bitbucket names one itself where the workspace has a default, which is why creating a repository has worked, and refuses the repository where it doesn't -- leaving the console reporting that the repository could not be created and nothing a user can do about it. The workspace is asked for a project and the create repeated with it, only where Bitbucket said the project was what it objected to. A name already taken, or a credential lacking the scope to create anything, is reported as it was.
Contributor
Greptile SummaryThe PR adds optional Bitbucket project selection when creating a repository while preserving the shared three-argument adapter contract.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (9): Last reviewed commit: "test(bitbucket): read the project key wh..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Bitbucket groups repositories under a project and asks for one when a repository is created, which GitHub and GitLab have no equivalent of. The caller can now name it, and the adapters that don't group repositories ignore what they're given.
Choosing a project for the caller put the repository somewhere nobody asked for, guessed from whichever the workspace listed first, and read the provider's wording to decide when to guess. A workspace that wants a project says so, and the caller now has a way to answer.
One test names the project the workspace already chose and reads it back off the repository. The other names one the workspace doesn't hold and expects the refusal, so a name that never left the adapter would fail it.
Meldiron
reviewed
Aug 11, 2026
Meldiron
reviewed
Aug 11, 2026
| * @return array<mixed> Details of new repository | ||
| */ | ||
| public function createRepository(string $owner, string $repositoryName, bool $private): array | ||
| public function createRepository(string $owner, string $repositoryName, bool $private, string $project = ''): array |
Contributor
There was a problem hiding this comment.
Lets not add project to all adapters, unless we know it is a feature. If project is bitbucket specific concept, we need to keep it bitbucket only
Meldiron
reviewed
Aug 11, 2026
Meldiron
reviewed
Aug 11, 2026
Comment on lines
+49
to
+51
| // Projects are Bitbucket's alone, so they are reached off the adapter | ||
| // itself rather than through the shared contract | ||
| private Bitbucket $bitbucket; |
Contributor
There was a problem hiding this comment.
Lets try to make Appwrite PR. Curious what this casting will look like there, for bitbuket specific behaviour
Contributor
There was a problem hiding this comment.
Worried this will be trouble, but not sure. Maybe PHP has some magic to make it nice
Member
Author
|
Not needed for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a repository fails on some Bitbucket workspaces with:
and the console reports only that the repository was not created.
Why
A Bitbucket repository belongs to a project — its own create form makes this explicit: "You must either select a project or create a new one." The adapter sends
scm,nameandis_privateand no project, so Bitbucket picks the workspace default. That works where a workspace has one, which is why creation succeeds in CI and on most workspaces, and fails where it doesn't or where that default is restricted.Change
Where Bitbucket's own error names the project as the objection, the workspace is asked for one and the create repeated with
project.key. Any other failure — a name already taken, a credential without the scope to create anything — is reported unchanged, so this doesn't retry things that will not succeed.GET /2.0/workspaces/{workspace}/projectsreturnsvalues[].key; the first is used.Not covered
The caller still can't choose which project. Doing that means carrying a project through
createRepository()and offering a picker in the console, the way Bitbucket's form does — worth doing, but a larger change than unblocking creation.