feat(platforms): Add helm chart for Vector installation#2232
feat(platforms): Add helm chart for Vector installation#2232alexgavrisco wants to merge 2 commits into
Conversation
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
2d3afca to
ee6ceec
Compare
|
Hey @Hoverbear @binarylogic |
|
Thanks @Alexx-G! It's likely we'll want to finalize #2222 before merging this. This way we'll have consensus on our approach and can review it with that context. Also, feel free to weigh in on that RFC as we update it. |
|
This totally makes sense. I'll take a look at the RFC, thanks! |
|
Hey! I just wanted to let you know I didn't forget about this PR. This looks great, and soon I'll finally get to reviewing it. We'll likely adopt it after some minor changes to conform to the RFC and our updated YAML configs. |
| --- | ||
| {{- if .Values.rbac.psp.enabled }} | ||
| apiVersion: {{ default (include "psp.apiVersion" .) .Values.rbac.psp.apiVersion }} | ||
| kind: PodSecurityPolicy |
There was a problem hiding this comment.
Minor nit: PodSecurityPolicy isn't really a part of RBAC, it should probably be in a separate file and manageable independently.
|
@Alexx-G thank you for taking the time to submit this. I'm going to close this in favor of #2871. Please let us know if we're missing anything that isn't covered here. We're planning to release our official k8s support soon. |
This PR adds a helm chart for Vector installation in a K8S cluster.
It's inspired from other similar community helm charts and some ideas are taken from #1900
IMO a community helm chart must support 2 major use cases:
--setarguments (or a values file);This is why in this helm chart the only source enabled by default (and exposed as separate entity in the
sourcesobject) is thekubernetessource. All other components can be easily configuring without coupling helm chart to some specific transforms/sinks.