fix(transfer): remap whole-bank mental model evidence - #3883
Closed
PaleRoses wants to merge 1 commit into
Closed
Conversation
Strix Security ReviewNo security issues found. Updated for Reviewed by Strix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Whole-bank import restores mental-model rows twice: once through the embedded document archive before regenerated fact IDs are known, then again through the bank-level restore after remapping. The second insert loses to
ON CONFLICT, leaving current evidence pointed at source-bank fact UUIDs. Historical evidence also stores its prior reflect response insidemental_model_history.content, which the existing remapper does not descend into.This is a follow-up to #3833.
Change
content.previous_reflect_response.based_onin mental-model history alongside current evidence.Verification
Before the patch:
After the patch: