feat(consolidation): protect closed vocabularies - #3889
Closed
PaleRoses wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Consolidation can merge two textually similar facts even when each names a different member of a deployment-owned closed vocabulary: environments, products, regions, branches, tenants, or other mutually exclusive terms. Prompt instructions alone do not reliably prevent the same substitution during CREATE, UPDATE, or semantic dedup.
Proposed contract
Add an opt-in
consolidation_protected_vocabulariessetting:[{"name":"environment","terms":["staging","production"]}]The name and fixtures are deliberately domain-neutral. This proposal contains no downstream project vocabulary.
Verification
pytest -q -n0 tests/test_consolidation_protected_vocabularies.py tests/test_hierarchical_config.py tests/test_bank_template_full_roundtrip.py tests/test_bank_template_configurable_fields.py— 82 passedpytest -q -n0 tests/test_consolidation_dedup.py tests/test_consolidation_retry_budget.py tests/test_consolidation_failure_isolation.py tests/test_consolidation_temporal_merge.py— 74 passedgit diff --check