Feat full e2e action#724
Open
mattmacf98 wants to merge 16 commits into
Open
Conversation
Adds a manual workflow_dispatch workflow that runs the full Playwright suite with --update-snapshots, then commits changed snapshot files and opens a PR if any snapshots changed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The src/lib/buf/ generated files were missing, causing 9 test files to fail with import resolution errors. Ran buf generate to produce the TypeScript protobuf bindings and updated buf.lock with the latest viamrobotics/api commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Contributor
|
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Authenticate with the Viam CLI using VIAM_KEY_ID and VIAM_KEY_VALUE repository secrets immediately after the CLI verification step. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The claude-ci-fix agent was failing tests because src/lib/buf/ (generated TypeScript protobuf bindings) is gitignored and not available after pnpm install. Added buf generate to the install_command so protos are ready before the agent runs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
keep_files: false would wipe pr-preview/ subdirectories on every main deploy. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The buf generate step was failing when the system buf cache at ~/.cache/buf had files owned by a different user. Using /tmp/buf-cache ensures a writable location regardless of prior cache state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
When BASE_URL is set, skip the local dev server and point Playwright directly at the provided URL (e.g. the deployed GitHub Pages site). The snapshot-update workflow now uses BASE_URL=https://viamrobotics.github.io/visualization/ and drops the Go setup + build steps since they are no longer needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The CI test job (claude-ci-fix.yml) runs `pnpm exec buf generate` as part of its install step. Without buf installed via pnpm, this falls back to the system PATH which has no buf binary on stock Linux CI runners, causing src/lib/buf generation to silently fail and all tests that import from $lib/buf/* to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.