Skip to content

[codex] Remove Effect filter instance ID shortcut#103

Closed
Dragoy wants to merge 1 commit into
virtualritz:masterfrom
Dragoy:codex/remove-effect-filter-instance-id
Closed

[codex] Remove Effect filter instance ID shortcut#103
Dragoy wants to merge 1 commit into
virtualritz:masterfrom
Dragoy:codex/remove-effect-filter-instance-id

Conversation

@Dragoy

@Dragoy Dragoy commented May 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove the high-level Effect::filter_instance_id() convenience wrapper from after-effects/src/pf/effect.rs.

The lower-level pf::suites::Utility::filter_instance_id() API remains available for callers that intentionally acquire and handle the Premiere utility suite. This avoids presenting the filter instance ID path as a generally available Effect method, since the underlying PF_UtilitySuite can be unavailable in some AE selectors/hosts and return MissingSuite.

Validation

  • cargo test -p after-effects

@Dragoy Dragoy marked this pull request as ready for review May 15, 2026 19:56
@virtualritz

Copy link
Copy Markdown
Owner

Thanks for the cleanup pass. Declining this one: the change removes a working, gracefully-failing convenience method (Effect::filter_instance_id, which already returns Err(MissingSuite) when the utility suite is unavailable), but the stated rationale -- that PF_UtilitySuite can be unavailable -- applies equally to the ~30 sibling utility wrappers generated in the same block (clip_name, clip_duration, media_timecode, etc.) that are left in place. Singling out one method makes the Effect API arbitrarily inconsistent and is a breaking public-API removal with no offsetting benefit. If we want a real API-safety cleanup here, it should be a deliberate, consistent pass over the whole wrapper block rather than a single-method trim. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants