Skip to content

[Feat] add tolerations to router deployment in helm chart - #1002

Open
formorter wants to merge 3 commits into
vllm-project:mainfrom
formorter:feat/helm_routerSpec_tolerations
Open

[Feat] add tolerations to router deployment in helm chart #1002
formorter wants to merge 3 commits into
vllm-project:mainfrom
formorter:feat/helm_routerSpec_tolerations

Conversation

@formorter

@formorter formorter commented Jul 21, 2026

Copy link
Copy Markdown

Adding tolerations to router deployment spec

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


  • Make sure the code changes pass the pre-commit checks.
  • Sign-off your commit by using -s when doing git commit
  • Try to classify PRs for easy understanding of the type of changes, such as [Bugfix], [Feat], and [CI].
Detailed Checklist (Click to Expand)

Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Feat] for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).
  • [Router] for changes to the vllm_router (e.g., routing algorithm, router observability, etc.).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • Pass all linter checks. Please use pre-commit to format your code. See README.md for installation.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Please include sufficient tests to ensure the change is stay correct and robust. This includes both unit tests and integration tests.

DCO and Signed-off-by

When contributing changes to this project, you must agree to the DCO. Commits must include a Signed-off-by: header which certifies agreement with the terms of the DCO.

Using -s with git commit will automatically add this header.

What to Expect for the Reviews

We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for configuring tolerations on the router deployment in the Helm chart. The review feedback correctly points out that tolerations should be defined as an empty list ([]) instead of an empty map ({}) in values.yaml to match the Kubernetes API specification, and recommends updating the corresponding schema file (helm/values.schema.json).

Comment thread helm/values.yaml
Comment on lines +446 to +451
# -- tolerations for router pod
tolerations: {}
# - key: key
# operator: Equal
# value: value
# effect: NoSchedule

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Kubernetes, tolerations is a list (array) of objects, not a map (object). The default value should be defined as an empty list [] instead of an empty map {} to maintain consistency with other tolerations in this file (e.g., servingEngineSpec.tolerations) and to align with the Kubernetes API specification.

Additionally, please remember to update helm/values.schema.json to define routerSpec.tolerations as an array type.

  # -- tolerations for router pod 
  tolerations: []
    # - key: key
    #   operator: Equal
    #   value: value
    #   effect: NoSchedule

@formorter
formorter force-pushed the feat/helm_routerSpec_tolerations branch 2 times, most recently from cafce97 to dfc7545 Compare July 21, 2026 09:26
@formorter formorter changed the title [Faet] add tolerations to router deployment in helm chart [Feat] add tolerations to router deployment in helm chart Jul 21, 2026
Signed-off-by: formorter <formorter@yandex.ru>
Signed-off-by: formorter <formorter@yandex.ru>
Signed-off-by: formorter <formorter@yandex.ru>
@formorter
formorter force-pushed the feat/helm_routerSpec_tolerations branch from bb1b412 to 86d7129 Compare July 21, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant