[Feat] add tolerations to router deployment in helm chart - #1002
[Feat] add tolerations to router deployment in helm chart #1002formorter wants to merge 3 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds support for configuring tolerations on the router deployment in the Helm chart. The review feedback correctly points out that tolerations should be defined as an empty list ([]) instead of an empty map ({}) in values.yaml to match the Kubernetes API specification, and recommends updating the corresponding schema file (helm/values.schema.json).
| # -- tolerations for router pod | ||
| tolerations: {} | ||
| # - key: key | ||
| # operator: Equal | ||
| # value: value | ||
| # effect: NoSchedule |
There was a problem hiding this comment.
In Kubernetes, tolerations is a list (array) of objects, not a map (object). The default value should be defined as an empty list [] instead of an empty map {} to maintain consistency with other tolerations in this file (e.g., servingEngineSpec.tolerations) and to align with the Kubernetes API specification.
Additionally, please remember to update helm/values.schema.json to define routerSpec.tolerations as an array type.
# -- tolerations for router pod
tolerations: []
# - key: key
# operator: Equal
# value: value
# effect: NoSchedulecafce97 to
dfc7545
Compare
Signed-off-by: formorter <formorter@yandex.ru>
Signed-off-by: formorter <formorter@yandex.ru>
Signed-off-by: formorter <formorter@yandex.ru>
bb1b412 to
86d7129
Compare
Adding tolerations to router deployment spec
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to production-stack! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews
We aim to address all PRs in a timely manner. If no one reviews your PR within 5 days, please @-mention one of YuhanLiu11
, Shaoting-Feng or ApostaC.