Bump Kubernetes client to 36.0.3 - #1013
Closed
arnaudgeiser wants to merge 1 commit into
Closed
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the versions of the aiohttp and kubernetes dependencies in pyproject.toml. The reviewer noted that these dependency updates should also be applied to src/vllm_router/requirements.txt to keep the definitions synchronized and avoid inconsistent environments.
Comment on lines
+18
to
+19
| "aiohttp[speedups]==3.14.3", | ||
| "kubernetes==36.0.3", |
Contributor
There was a problem hiding this comment.
The dependencies aiohttp and kubernetes have been updated here, but src/vllm_router/requirements.txt still references the older versions (aiohttp[speedups]==3.13.3 and kubernetes==32.0.0). Please update src/vllm_router/requirements.txt to keep the dependency definitions synchronized and avoid inconsistent environments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.