Ignore PyO3 rustsec#8381
Conversation
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
Signed-off-by: Connor Tsui <connor.tsui20@gmail.com>
gatesn
left a comment
There was a problem hiding this comment.
Let's make this not a required check for branches, but still required before release
Merging this PR will improve performance by 26.18%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
35.5 µs | 20.5 µs | +72.93% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(1000, 10)] |
198.1 µs | 161.9 µs | +22.35% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
213.5 µs | 177.4 µs | +20.39% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ct/pyo3-rustsec (258839b) with develop (8acef3a)
|
These aren't required checks already |
AdamGS
left a comment
There was a problem hiding this comment.
I think this is fine, as far as I can tell we don't use those code paths, and this is a relatively minor dependency.
Summary
Ignores the pyo3 rustsec because there are other dependencies that haven't upgraded yet.
Testing
N/A