Skip to content

Remove debug symbols from vortex-fastlanes on dev profile#8383

Merged
AdamGS merged 1 commit into
developfrom
adamg/fastlanes-debug-symbols
Jun 12, 2026
Merged

Remove debug symbols from vortex-fastlanes on dev profile#8383
AdamGS merged 1 commit into
developfrom
adamg/fastlanes-debug-symbols

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Inspired by @myrrc's #8634, this change makes a few subtle changes to our dev and ci build profiles. The main change here is removing debug symbols from vortex-fastlanes, which for a full build of the main package (cargo build -p vortex --all-features --all-targets) reduces build time by about 33% (from 90 seconds to under 60).

The others are:

  1. For the ci profile, enables debug_assertions and remove the explicit strip which seems redundant, and doesn't seem to make a measurable difference in build times.
  2. Remove vortex-bench as a dev dependency for vortex, which is just weird and unused.

@AdamGS AdamGS requested review from a team, joseph-isaacs and myrrc June 12, 2026 07:32
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 96.42%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 15 improved benchmarks
❌ 3 regressed benchmarks
✅ 1508 untouched benchmarks
⏩ 10 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_varbinview_canonical_into[(1000, 10)] 161.4 µs 198.1 µs -18.49%
Simulation decompress_rd[f64, (100000, 0.0)] 845.6 µs 980 µs -13.71%
Simulation bitwise_not_vortex_buffer_mut[128] 215.3 ns 244.4 ns -11.93%
Simulation count_i32_clustered_nulls 640.9 µs 55.2 µs ×12
Simulation sum_f64_all_valid 293.2 µs 38.2 µs ×7.7
Simulation sum_i32_clustered_nulls 543.6 µs 71.8 µs ×7.6
Simulation sum_f64_clustered_nulls 547.3 µs 74.6 µs ×7.3
Simulation sum_i32_nullable_all_valid 334.7 µs 73 µs ×4.6
Simulation count_varbinview 253.1 µs 75.9 µs ×3.3
Simulation decompress_rd[f64, (10000, 0.0)] 138.5 µs 110.9 µs +24.88%
Simulation decompress_rd[f64, (10000, 0.1)] 138.3 µs 110.9 µs +24.71%
Simulation decompress_rd[f64, (10000, 0.01)] 137.9 µs 110.6 µs +24.69%
Simulation sum_f64 711.9 µs 594.3 µs +19.8%
Simulation chunked_varbinview_canonical_into[(100, 100)] 307.9 µs 273.5 µs +12.58%
Simulation decompress_rd[f32, (10000, 0.1)] 90 µs 80.3 µs +12.11%
Simulation decompress_rd[f32, (10000, 0.0)] 90.2 µs 80.9 µs +11.61%
Simulation decompress_rd[f32, (10000, 0.01)] 90 µs 80.8 µs +11.35%
Simulation encode_varbin[(1000, 2)] 175.6 µs 158.4 µs +10.85%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/fastlanes-debug-symbols (9ac6a8e) with develop (a3c5f8c)2

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on develop (d70c77e) during the generation of this report, so a3c5f8c was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Comment thread vortex/Cargo.toml
tracing = { workspace = true }
tracing-subscriber = { workspace = true }
vortex = { path = ".", features = ["tokio"] }
vortex-bench = { workspace = true, features = ["unstable_encodings"] }

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also potentially a pretty big speedup in many cases

Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/fastlanes-debug-symbols branch from c878593 to 9ac6a8e Compare June 12, 2026 11:15
@AdamGS AdamGS merged commit 3731d5b into develop Jun 12, 2026
87 of 93 checks passed
@AdamGS AdamGS deleted the adamg/fastlanes-debug-symbols branch June 12, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants