Containerize the musl tests#8387
Conversation
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Merging this PR will improve performance by 24.19%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | chunked_bool_canonical_into[(1000, 10)] |
35.4 µs | 20.5 µs | +73.06% |
| ⚡ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
212.9 µs | 176.8 µs | +20.46% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[128] |
244.4 ns | 215.3 ns | +13.55% |
| ⚡ | Simulation | chunked_varbinview_canonical_into[(100, 100)] |
307.9 µs | 272.8 µs | +12.86% |
| ⚡ | Simulation | bitwise_not_vortex_buffer_mut[1024] |
304.7 ns | 275.6 ns | +10.58% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing adamg/containerize-musl-tests (ee79461) with develop (c7e0d17)
Footnotes
-
10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
e806e8c to
97039a1
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
97039a1 to
1cb227b
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
1a2f2c8 to
12d04ad
Compare
| --exclude vortex-cuda --exclude vortex-cub --exclude vortex-nvcomp \ | ||
| --exclude gpu-scan-cli --exclude vortex-test-e2e-cuda \ | ||
| --exclude vortex-duckdb --exclude duckdb-bench --exclude vortex-sqllogictest \ | ||
| --exclude vortex-bench --exclude lance-bench --exclude datafusion-bench --exclude vortex-datafusion |
There was a problem hiding this comment.
trying to exclude even more crates, no reason to build so much stuff
12d04ad to
dc1a9cb
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
dc1a9cb to
83b5a87
Compare
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Summary
Instead of running the whole workflow with a docker one-liner, run a containerized job. I think this is much easier to read and maintain.