Skip to content

Containerize the musl tests#8387

Merged
AdamGS merged 9 commits into
developfrom
adamg/containerize-musl-tests
Jun 12, 2026
Merged

Containerize the musl tests#8387
AdamGS merged 9 commits into
developfrom
adamg/containerize-musl-tests

Conversation

@AdamGS

@AdamGS AdamGS commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Instead of running the whole workflow with a docker one-liner, run a containerized job. I think this is much easier to read and maintain.

AdamGS added 2 commits June 12, 2026 10:51
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@codspeed-hq

codspeed-hq Bot commented Jun 12, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 24.19%

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

⚡ 5 improved benchmarks
✅ 1521 untouched benchmarks
⏩ 10 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation chunked_bool_canonical_into[(1000, 10)] 35.4 µs 20.5 µs +73.06%
Simulation chunked_varbinview_into_canonical[(1000, 10)] 212.9 µs 176.8 µs +20.46%
Simulation bitwise_not_vortex_buffer_mut[128] 244.4 ns 215.3 ns +13.55%
Simulation chunked_varbinview_canonical_into[(100, 100)] 307.9 µs 272.8 µs +12.86%
Simulation bitwise_not_vortex_buffer_mut[1024] 304.7 ns 275.6 ns +10.58%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.


Comparing adamg/containerize-musl-tests (ee79461) with develop (c7e0d17)

Open in CodSpeed

Footnotes

  1. 10 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@AdamGS AdamGS force-pushed the adamg/containerize-musl-tests branch from e806e8c to 97039a1 Compare June 12, 2026 10:14
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/containerize-musl-tests branch from 97039a1 to 1cb227b Compare June 12, 2026 10:20
AdamGS added 4 commits June 12, 2026 11:22
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS marked this pull request as ready for review June 12, 2026 10:32
@AdamGS AdamGS requested a review from a team June 12, 2026 10:32
@AdamGS AdamGS force-pushed the adamg/containerize-musl-tests branch from 1a2f2c8 to 12d04ad Compare June 12, 2026 10:35
Comment thread .github/workflows/musl.yml Outdated
--exclude vortex-cuda --exclude vortex-cub --exclude vortex-nvcomp \
--exclude gpu-scan-cli --exclude vortex-test-e2e-cuda \
--exclude vortex-duckdb --exclude duckdb-bench --exclude vortex-sqllogictest \
--exclude vortex-bench --exclude lance-bench --exclude datafusion-bench --exclude vortex-datafusion

@AdamGS AdamGS Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trying to exclude even more crates, no reason to build so much stuff

@AdamGS AdamGS force-pushed the adamg/containerize-musl-tests branch from 12d04ad to dc1a9cb Compare June 12, 2026 10:38
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS force-pushed the adamg/containerize-musl-tests branch from dc1a9cb to 83b5a87 Compare June 12, 2026 10:45
Signed-off-by: Adam Gutglick <adam@spiraldb.com>
@AdamGS AdamGS enabled auto-merge (squash) June 12, 2026 11:01
@AdamGS AdamGS merged commit a3c5f8c into develop Jun 12, 2026
61 of 62 checks passed
@AdamGS AdamGS deleted the adamg/containerize-musl-tests branch June 12, 2026 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants