refactor(usb-drive): move mock-platform selection to app composition roots#8744
Draft
eventualbuddha wants to merge 1 commit into
Conversation
…roots `detectUsbDrive`/`detectMultiUsbDrive` no longer consult the USE_MOCK_USB_DRIVE flag — they are deterministic over the platform they are given. App backends decide explicitly via `getSimulatedUsbPlatform()`, which returns the simulated platform when the flag is set and undefined (real hardware) otherwise. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<🤖>detectUsbDrive/detectMultiUsbDriveno longer consult the USE_MOCK_USB_DRIVE flag — they are deterministic over the platform they are given. App backends decide explicitly viagetSimulatedUsbPlatform(), which returns the simulated platform when the flag is set and undefined (real hardware) otherwise.</🤖>Overview
(Part 13 of a series of PRs: previous / next)
TODO
Demo Video or Screenshot
TODO
Testing Plan
TODO