Add unit test for ChannelPutData#943
Open
yosuke-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an internal unit test to validate SSH channel receive-window enforcement by ChannelPutData() (via a new wolfSSH_TestChannelPutData() test hook), ensuring oversized writes are rejected both initially and after partially consuming the window.
Changes:
- Expose
ChannelPutData()to internal unit tests viawolfSSH_TestChannelPutData()underWOLFSSH_TEST_INTERNAL. - Add
test_ChannelPutData()totests/unit.cto assertWS_FATAL_ERRORwhen input exceeds the channel window (including after window consumption). - Register the new unit test in the unit-test runner output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| wolfssh/internal.h | Declares new internal-test hook wolfSSH_TestChannelPutData() under WOLFSSH_TEST_INTERNAL. |
| src/internal.c | Implements wolfSSH_TestChannelPutData() wrapper calling ChannelPutData(). |
| tests/unit.c | Adds and runs test_ChannelPutData() validating window enforcement and bad-argument handling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yosuke-wolfssl
assigned
wolfSSL-Bot and
yosuke-wolfssl and unassigned
yosuke-wolfssl and
wolfSSL-Bot
Contributor
Author
|
Hello @ejohnstown , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a unit test that creates a channel with a small windowSz (e.g., 100 bytes), then calls ChannelPutData with a buffer larger than the window. Verify that WS_FATAL_ERROR is returned. Also verify that after consuming window with valid data, exceeding the remaining window is rejected.