Custom Posts: Show "Post updated" notice #25576
+125
−30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import Foundation | ||
|
|
||
| /// Localized titles for the success notices emitted when a custom post is | ||
| /// persisted to the server. Shared between the editor, the publishing sheet, | ||
| /// and the Custom Posts list. | ||
| enum CustomPostNoticeStrings { | ||
|
Contributor
There was a problem hiding this comment. Optional follow-on to the three whitespace nits: the trim + empty→nil logic now repeats at all three notice sites. Since this enum is already the shared home, a small helper would keep it in one place: static func subtitle(from rawTitle: String?) -> String? {
let trimmed = rawTitle?.trimmingCharacters(in: .whitespacesAndNewlines)
return trimmed?.isEmpty == false ? trimmed : nil
}Then each call site becomes |
||
| static let draftSaved = NSLocalizedString( | ||
| "customPost.notice.draftSaved", | ||
| value: "Draft saved", | ||
| comment: "Success notice shown after a new draft custom post is created on the server." | ||
| ) | ||
| static let postUpdated = NSLocalizedString( | ||
| "customPost.notice.postUpdated", | ||
| value: "Post updated", | ||
| comment: "Success notice shown after an existing custom post is updated on the server." | ||
| ) | ||
| static let postPublished = NSLocalizedString( | ||
| "customPost.notice.postPublished", | ||
| value: "Post published", | ||
| comment: "Success notice shown after a custom post is published on the server." | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -81,7 +81,14 @@ final class PublishPostViewController<ViewModel: PostSettingsViewModelProtocol>: | |||||
| editorService: editorService, | ||||||
| blog: blog | ||||||
| ) | ||||||
| publishVC.onCompletion = { result in | ||||||
| if case .published = result { | ||||||
| let postTitle = editorService.post?.title?.raw | ||||||
|
Contributor
There was a problem hiding this comment. Cosmetic: a whitespace-only title slips past
Suggested change
Contributor
Author
There was a problem hiding this comment. The trimming is redundant since the site trims already. whitespaces.mov |
||||||
| let subtitle = (postTitle?.isEmpty == false) ? postTitle : nil | ||||||
| Notice(title: CustomPostNoticeStrings.postPublished, message: subtitle, feedbackType: .success).post() | ||||||
| } | ||||||
| completion(result) | ||||||
| } | ||||||
| let navigationVC = UINavigationController(rootViewController: publishVC) | ||||||
| navigationVC.sheetPresentationController?.detents = [ | ||||||
| .custom(identifier: .medium, resolver: { _ in 526 }), | ||||||
|
|
@@ -221,23 +228,82 @@ private typealias Strings = PrepublishingSheetStrings | |||||
|
|
||||||
| enum PrepublishingSheetStrings { | ||||||
| static let title = NSLocalizedString("prepublishing.title", value: "Publishing", comment: "Navigation title") | ||||||
| static let publishingTo = NSLocalizedString( | ||||||
| "prepublishing.publishingTo", | ||||||
| value: "Publishing to", | ||||||
| comment: "Label in the header in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let publish = NSLocalizedString( | ||||||
| "prepublishing.publish", | ||||||
| value: "Publish", | ||||||
| comment: "Primary button label in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let schedule = NSLocalizedString( | ||||||
| "prepublishing.schedule", | ||||||
| value: "Schedule", | ||||||
| comment: "Primary button label in the pre-publishing shee" | ||||||
| ) | ||||||
| static let publishDate = NSLocalizedString( | ||||||
| "prepublishing.publishDate", | ||||||
| value: "Publish Date", | ||||||
| comment: "Label for a cell in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let visibility = NSLocalizedString( | ||||||
| "prepublishing.visibility", | ||||||
| value: "Visibility", | ||||||
| comment: "Label for a cell in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let categories = NSLocalizedString( | ||||||
| "prepublishing.categories", | ||||||
| value: "Categories", | ||||||
| comment: "Label for a cell in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let tags = NSLocalizedString( | ||||||
| "prepublishing.tags", | ||||||
| value: "Tags", | ||||||
| comment: "Label for a cell in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let jetpackSocial = NSLocalizedString( | ||||||
| "prepublishing.jetpackSocial", | ||||||
| value: "Jetpack Social", | ||||||
| comment: "Label for a cell in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let immediately = NSLocalizedString( | ||||||
| "prepublishing.publishDateImmediately", | ||||||
| value: "Immediately", | ||||||
| comment: "Placeholder value for a publishing date in the prepublishing sheet when the date is not selected" | ||||||
| ) | ||||||
| static let uploadingMedia = NSLocalizedString( | ||||||
| "prepublishing.uploadingMedia", | ||||||
| value: "Uploading media", | ||||||
| comment: "Title for a publish button state in the pre-publishing sheet" | ||||||
| ) | ||||||
| private static let uploadMediaOneItemRemaining = NSLocalizedString( | ||||||
| "prepublishing.uploadMediaOneItemRemaining", | ||||||
| value: "%@ item remaining", | ||||||
| comment: "Details label for a publish button state in the pre-publishing sheet" | ||||||
| ) | ||||||
| private static let uploadMediaManyItemsRemaining = NSLocalizedString( | ||||||
| "prepublishing.uploadMediaManyItemsRemaining", | ||||||
| value: "%@ items remaining", | ||||||
| comment: "Details label for a publish button state in the pre-publishing sheet" | ||||||
| ) | ||||||
| static func uploadMediaRemaining(count: Int) -> String { | ||||||
| String( | ||||||
| format: count == 1 ? Strings.uploadMediaOneItemRemaining : Strings.uploadMediaManyItemsRemaining, | ||||||
| count.description | ||||||
| ) | ||||||
| } | ||||||
| static let mediaUploadFailedTitle = NSLocalizedString( | ||||||
| "prepublishing.mediaUploadFailedTitle", | ||||||
| value: "Failed to upload media", | ||||||
| comment: "Title for a publish button state in the pre-publishing sheet" | ||||||
| ) | ||||||
| static let mediaUploadFailedDetailsMultipleFailures = NSLocalizedString( | ||||||
| "prepublishing.mediaUploadFailedDetails", | ||||||
| value: "%@ items failed to upload", | ||||||
| comment: "Details for a publish button state in the pre-publishing sheet; count as a parameter" | ||||||
| ) | ||||||
|
|
||||||
| static let discardChangesTitle = NSLocalizedString( | ||||||
| "prepublishing.discardChanges.title", | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same whitespace nit as the publishing sheet — trim so a blank title doesn't show an empty subtitle line: