feat: improve processor reloading and allow it for SSL - #87
Open
reneca wants to merge 4 commits into
Open
Conversation
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
Signed-off-by: Jeremy HERGAULT <jeremy.hergault@worldline.com>
oschijns
reviewed
Aug 31, 2026
Comment on lines
+344
to
+347
| pub fn reload_proc<S>(&self, proc: &dyn ProcBusParam, adaptor: &dyn Adaptor) -> Option<S> | ||
| where | ||
| S: DeserializeOwned, | ||
| { |
Contributor
There was a problem hiding this comment.
It is a bit odd that a function that can potential fail returns a Option type instead of an Result type.
Contributor
Author
There was a problem hiding this comment.
Yes I agree. I've changed.
| snapshot with `SslConfigContext`, use the lower-level `Stream::connect_openssl` API, and replace the | ||
| snapshot only when their certificate source reports a change. | ||
|
|
||
| Both settings implement `PartialEq`, and `set_alpn()` is idempotent, so normalise before comparing. |
Contributor
There was a problem hiding this comment.
What does it means to normalize ?
so normalise before comparing
Contributor
Author
There was a problem hiding this comment.
It means that if you call set_alpn, it alter the Url so your settings will not be the same. But I think it's just noise in that case. I removed it.
Signed-off-by: Jeremy HERGAULT <jeremy@hergault.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must have to do ProSA-Hyper upgrade to ProSA 0.5.