Fix 2 flaky tests#885
Open
kvch wants to merge 1 commit into
Open
Conversation
Merging this branch will not change overall coverage
Coverage by fileChanged unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes 2 flaky tests:
pkg/wal/processor/transformer/wal_postgres_anon_rule_parser_test.goTwo subtests running in parallel registered a call to remove the same rules file. The error-marshaler case never creates a file, but its deferred cleanup still calls
os.Remove. It can delete the success case's file before its os.Stat check runs.pkg/wal/processor/webhook/notifier/webhook_notifier_test.goThe test calls
ProcessWALEventin a default branch and asserts on the lastprocessErrwhendoneChanfires. Now the notifier guarantees that anyProcessWALEventcalled afterNotifyexits will see the closednotifyDoneand return the wrapped error. So the fix is to make one moreProcessWALEventcall inside thedoneChancase before asserting.Type of Change
Please select the relevant option(s):