Skip to content

Changes in Acto for running tests on kubeblocks postgresql operator#331

Open
raunaks13 wants to merge 7 commits into
xlab-uiuc:mainfrom
raunaks13:main
Open

Changes in Acto for running tests on kubeblocks postgresql operator#331
raunaks13 wants to merge 7 commits into
xlab-uiuc:mainfrom
raunaks13:main

Conversation

@raunaks13

Copy link
Copy Markdown
Contributor

Mainly 3 changes -

  1. Added scope for running kubectl create -f file along with apply and wait commands.
  2. Removed server-side flag while running kubectl apply since that prevented kubeblocks addon extensions from being deployed successfully
  3. Added a folder with some useful data for the kubeblocks postgresql operator (similar to other operators present in the data folder)

@tianyin

tianyin commented Feb 25, 2024

Copy link
Copy Markdown
Member

@raunaks13 Thanks for the PR!

Could you break the PR into two or even three? Each PR should focus on a small thing and only one thing at a time.

#3 is apparently different from #1 and #2.

I'm not sure if #1 and #2 are correlated or not.

@ziyue-pan

Copy link
Copy Markdown

I met with the same issues caused by server-side flags. But there are cases in which a server-side flag is necessary.

Regarding 2, I have an idea of adding an option "server-side": true/false (default to true) to control the flag manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants