ci: adopt shared rust-ci workflow for farp-rust - #23
Merged
Conversation
Replace the inline rust-test job (dtolnay toolchain, cargo fmt/clippy/ test/tarpaulin/doc, guarded by a check_cargo step) with a call to xraph/workflows/.github/workflows/rust-ci.yml@v1. - working-directory: farp-rust (the crate exists unconditionally, so the check_cargo guard is dropped) - run-extended only on pushes to main - skip-audit: true, since farp-rust is a library crate and its Cargo.lock is intentionally gitignored (no lockfile to audit) Dropped: cargo tarpaulin coverage, which ran under continue-on-error: true and therefore never gated the job. rust-ci.yml has no coverage job; this is a deliberate, recorded loss of that capability, not a silent one.
Contributor
|
🎉 This PR is included in version 1.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rust-testjob with a call toxraph/workflows/.github/workflows/rust-ci.yml@v1, usingworking-directory: farp-rust.run-extendedis gated to pushes onmainonly.skip-audit: true—farp-rustis a library crate and itsCargo.lockis intentionally gitignored, so there is no lockfile forcargo auditto check.Dropped capability (recorded, not silent)
The old job ran
cargo tarpaulinfor coverage undercontinue-on-error: true.rust-ci.ymlhas no coverage job. Since that step could never fail the build, it wasn't gating anything — dropping it is a deliberate decision, not a silent loss. A shared tarpaulin/coverage job forrust-ci.ymlis tracked as a follow-up iffarporoctopuswant it back.Scope
Only the
rust-testjob in.github/workflows/ci.ymlchanges. Go jobs, CodeQL,badges.yml, andrelease.yml's semantic-release pipeline are untouched.Test plan
actionlintshows no new findings introduced by this diff (pre-existing shellcheck findings inrelease.ymlare unrelated and predate this change)cargo fmt --all -- --checkandcargo clippy --all-targets --all-features -- -D warningspass infarp-rust, matching the stricter flags used byrust-ci.ymlrust-test(lint, audit-skip, test) passes