fix(cli): drop redundant newlines from Println help output - #44
Merged
Conversation
go vet treats cli.CommandContext.Println as a Println-style print wrapper, so the four help-text calls ending in "\n" tripped the "arg list ends with redundant newline" check and failed the build. Emit the blank separator lines with a bare ctx.Println() instead. Output is unchanged: Fprintln with no args writes exactly one newline.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Conventional Commits ValidationPR Title: valid |
pion/webrtc v3.3.6 is the last v3 release and pins dtls/v2 and stun, which carry: CVE-2026-26014 pion/dtls <=2.2.12 random nonce reuse with AES-GCM risks leaking the authentication key CVE-2026-54909 pion/stun <=1.23.1 remote DoS via panic parsing a malformed XOR-MAPPED-ADDRESS attribute Both fixes landed only behind new major import paths, so Dependabot reports "no patched version" and cannot bump them automatically. Moving to webrtc/v4 pulls dtls/v3 and stun/v3 and retires the rest of the v2 generation (ice/v2->v4, turn/v2->v5, transport/v2->v4, srtp/v2->v3, mdns->mdns/v2). No API changes were needed: the only source edits are the six import paths. go mod tidy also drops testify and go-difflib; the tests in this module use plain stdlib testing and never imported them. Verified with GOWORK=off (this module is not in go.work): build, vet and test all pass.
Contributor
Conventional Commits ValidationPR Title: valid |
The "Build and vet all modules" loop builds each module standalone, so cmd/forge compiled against the last PUBLISHED github.com/xraph/forge rather than this checkout. Root API added on a branch but not yet released therefore failed the job: plugins/client.go:401:23: undefined: client.PathFilter plugins/client.go:437:3: unknown field PathFilter in GeneratorConfig plugins/client.go:438:3: unknown field ReactQuery in GeneratorConfig cmd/forge/go.mod cannot carry a replace directive - `go install ...@latest` rejects any module that has one - so the fix is a throwaway workspace, the same one the Build CLI job already creates. The workspace file lives in RUNNER_TEMP rather than the repo root: a go.work at the root applies to every module in the loop, and the 37 it does not list would fail with "directory prefix . does not contain modules listed in go.work". Only cmd/forge and extensions/database use it; everything else builds with GOWORK=off, which is what a fresh checkout already did since go.work is gitignored. Applied to the Test submodules loop too - it had the same defect and would have failed identically once the build passed. Also read mod_name from the module line instead of `head -1`, which picked up the first line of a comment and logged "./cmd/forge (Do)". Verified by running both extracted step scripts locally: all 39 modules build and vet, and cmd/forge's tests pass under the workspace.
Contributor
Conventional Commits ValidationPR Title: valid |
The 69 MB arm64 binary was committed before .gitignore grew its compiled-example-binary rules, and git ignores nothing it already tracks. Every `go build ./...` in that module rewrote the file, so it showed as modified locally and dirtied CI's build-and-vet loop. No .gitignore change needed: examples/*/[!.]* already covers it.
Contributor
Conventional Commits ValidationPR Title: valid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go vet treats cli.CommandContext.Println as a Println-style print wrapper, so the four help-text calls ending in "\n" tripped the "arg list ends with redundant newline" check and failed the build.
Emit the blank separator lines with a bare ctx.Println() instead. Output is unchanged: Fprintln with no args writes exactly one newline.