fix: make upstream tests pass#3920
Merged
d-v-b merged 3 commits intozarr-developers:mainfrom Apr 22, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3920 +/- ##
=======================================
Coverage 93.11% 93.11%
=======================================
Files 85 85
Lines 11365 11365
=======================================
Hits 10582 10582
Misses 783 783
🚀 New features to boost your workflow:
|
maxrjones
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have 2 failures in our upstream tests. One is caused by NumPy deprecating the creation of a
NaTdatetime without an explicitly declared unit, and the fix is to declare a unit when creating aNaTdatetime. The second failure has an unknown cause but was fixed by bumping the version of ml_dtypes used in an example script.