Skip to content

fix: make upstream tests pass#3920

Merged
d-v-b merged 3 commits intozarr-developers:mainfrom
d-v-b:fix/handle-upstream-breakage
Apr 22, 2026
Merged

fix: make upstream tests pass#3920
d-v-b merged 3 commits intozarr-developers:mainfrom
d-v-b:fix/handle-upstream-breakage

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented Apr 22, 2026

We have 2 failures in our upstream tests. One is caused by NumPy deprecating the creation of a NaT datetime without an explicitly declared unit, and the fix is to declare a unit when creating a NaT datetime. The second failure has an unknown cause but was fixed by bumping the version of ml_dtypes used in an example script.

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label Apr 22, 2026
@github-actions github-actions Bot removed the needs release notes Automatically applied to PRs which haven't added release notes label Apr 22, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.11%. Comparing base (8217046) to head (e41a98f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3920   +/-   ##
=======================================
  Coverage   93.11%   93.11%           
=======================================
  Files          85       85           
  Lines       11365    11365           
=======================================
  Hits        10582    10582           
  Misses        783      783           
Files with missing lines Coverage Δ
src/zarr/core/dtype/npy/time.py 98.85% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@d-v-b d-v-b requested a review from a team April 22, 2026 13:19
@d-v-b d-v-b merged commit 866aa8d into zarr-developers:main Apr 22, 2026
28 of 29 checks passed
@d-v-b d-v-b deleted the fix/handle-upstream-breakage branch April 22, 2026 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants