chore: use Debian Trixie devcontainers - #38
Closed
PabloZaiden wants to merge 1 commit into
Closed
Conversation
Move built-in templates, examples, and the development container to the official Debian Trixie base while retaining the ubuntu template identifier for compatibility. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
User-facing messaging/docs describe a “Debian Trixie template” fallback even though the actual fallback template identifier remains ubuntu, which is misleading and should be corrected for clarity/compatibility.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR migrates devbox’s built-in devcontainer templates, examples, and repository devcontainer from the Ubuntu noble base image to the Debian Trixie base image while keeping the public ubuntu template identifier for compatibility.
Changes:
- Switch built-in template base image constants from
mcr.microsoft.com/devcontainers/base:nobleto...:trixieand update template descriptions accordingly. - Update CLI/help text, README, and tests to reflect the Debian Trixie-based defaults and expected generated configs.
- Update example workspaces and repo
.devcontainer/devcontainer.jsonto use the Trixie base image.
File summaries
| File | Description |
|---|---|
| tests/templates.test.ts | Updates expectations for built-in templates to use the Trixie base image and updated descriptions. |
| tests/examples.test.ts | Updates example workspace assertions for generated configs and fallback messaging under the Trixie base. |
| tests/examples.live.test.ts | Updates live test expectations for fallback messaging under the Trixie base. |
| tests/core.test.ts | Updates help text expectations for the new fallback wording and base image. |
| src/templates.ts | Changes built-in template base constants to trixie and updates template descriptions/runtime labels. |
| src/core.ts | Updates CLI help text to describe the new fallback behavior. |
| src/cli.ts | Updates the runtime console message emitted when the fallback template is selected. |
| README.md | Updates documentation to describe Debian Trixie-based defaults and the built-in template list. |
| examples/smoke-workspace/.devcontainer/devcontainer.json | Switches example workspace base image to ...:trixie. |
| examples/complex-workspace/.devcontainer/devcontainer.json | Switches example workspace base image to ...:trixie. |
| .devcontainer/devcontainer.json | Updates repo devcontainer to Debian Trixie naming/linking and base image ...:trixie. |
Review details
Suppressed comments (1)
README.md:114
- This section refers to an "automatic Debian Trixie fallback", but the persisted template identifier is still
ubuntu(now backed by Debian Trixie). Using the template name in the docs makes it clearer what will be saved in.devbox/state.jsonand how to explicitly select the same behavior.
If no repo devcontainer is found and no previous template source is stored, `devbox up` automatically starts from the built-in Debian Trixie template. `devbox rebuild <port>` does the same when there is enough information to create the devbox but no prior workspace state exists. Devbox prints a message when this automatic fallback is used.
`devbox rebuild` reuses the previously selected source for the workspace. If the workspace was started from `--template` or the automatic Debian Trixie fallback, rebuild uses that saved template again. `rebuild --template ...` is intentionally not supported.
- Files reviewed: 11/11 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
182
to
184
| if (resolvedConfig.templateSelection === "fallback") { | ||
| console.log("No devcontainer definition found; using built-in ubuntu template."); | ||
| console.log("No devcontainer definition found; using built-in Debian Trixie template."); | ||
| } |
Comment on lines
+159
to
+160
| " up Start or reuse the managed devcontainer; falls back to the built-in Debian Trixie template when none is found.", | ||
| " rebuild Recreate the managed devcontainer; falls back to the built-in Debian Trixie template when no repo devcontainer or prior state exists.", |
| ## What it does | ||
|
|
||
| - Discovers `.devcontainer/devcontainer.json` or `.devcontainer.json` in the current directory, can target `.devcontainer/<subpath>/devcontainer.json` with a flag, and falls back to the built-in `ubuntu` template when no repo devcontainer is present. | ||
| - Discovers `.devcontainer/devcontainer.json` or `.devcontainer.json` in the current directory, can target `.devcontainer/<subpath>/devcontainer.json` with a flag, and falls back to the built-in Debian Trixie template when no repo devcontainer is present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcr.microsoft.com/devcontainers/base:nobletomcr.microsoft.com/devcontainers/base:trixieubuntutemplate identifier for compatibilityThe official
mcr.microsoft.com/devcontainers/base:trixietag is available.