Emit the SensorKit Structured Summaries and Declared Payload Formats - #69
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fa4f839 to
b93798d
Compare
bcdbe25 to
04ab3b9
Compare
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit # Conflicts: # Scripts/validate-fhir-conformance.sh
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
…' into feature/grove-fhir-0.2-sensorkit
|
|
||
|
|
||
| /// Builds source-neutral R4 graphs for sampled data, ECG, and native recordings. | ||
| public struct GroveSensorFHIRConverter: Sendable { |
There was a problem hiding this comment.
imo the naming here (ie, on this particular type, and also in the rest of the file and the PR) is too specific. we're in the Grove target already, so imo we should drop the Grove prefix from the types and call it eg just SensorFHIRConverter
There was a problem hiding this comment.
most of the types in this file feel like they should be nested elsewhere? (eg the Context, the Conversion, the ConversionError, ...)
…' into feature/grove-fhir-0.2-sensorkit
b8f786e
into
feature/grove-fhir-0.2-healthkit
♻️ Current situation & Problem
Three SensorKit streams had structured profiles; the rest were admitted only as opaque recordings. A receiver could store the bytes but could not tell how many samples arrived, over what interval, or in what format — the recording
DocumentReferencecarried a media type and nothing else, soapplication/jsoncould have been any shape at all.⚙️ Release Notes
content.formatnow names the exact registry entry, is validated against the formats its stream admits, and an unregistered code fails closed.rawFormatsthrough the generated contract so a producer reads the registry code from the catalog rather than hardcoding it.study.example.org, which the official Validator rejects outside published examples.📚 Documentation
The payload formats are specified in the sensor guide's Recording formats page, generated from the machine registry; the structured profiles are published in the SensorKit guide.
✅ Testing
derivedFromwiring, output identity, and format codings, plus fail-closed tests for zero durations, negative counts, and unregistered formats.swift build, SwiftLint strict, the package test suite, and the generator--checkgates pass, along with the HealthKit suite carried in by the merge.