Publish SensorKit Recordings as FHIR Observations - #61
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This implementation should be preserved, but its contract target is changing. grove-fhir #10 now tracks the platform-neutral model for coded sensor events, bounded waveforms, multichannel samples, significant-location/device-usage summaries, and large raw recordings. Before this PR is treated as the final conformant SensorKit layer, it should be restacked/reworked against the accepted generalized shapes rather than the provisional SensorKit-specific profiles. The existing mappings, archive utilities, identifiers, tests, and fixtures remain valuable implementation evidence. The design also needs parity with the actual My Heart Counts workload: ECG/PPG, accelerometer and other raw series, This deliberately keeps the PR available while #10 is resolved; it is not a request to discard the branch, merge it now, or change any runner assignment. |
2c2a7c6 to
9e37197
Compare
899879e to
c3a9543
Compare
515b1a9 to
72c73f0
Compare
1bbf763 to
3bc7487
Compare
72c73f0 to
356b3b3
Compare
3bc7487 to
78957a7
Compare
356b3b3 to
a1fb532
Compare
|
Superseded by #69, which rewrites this work on the catalog-driven converter and the published v0.2 profiles. Sensor coverage, stable output identity, metadata-key handling and device provenance all carry over; the vocabulary is now sourced from the grove-fhir catalogs with a CI drift check rather than a golden dump in this repo. |
♻️ Current situation & Problem
SensorKit recordings had no FHIR representation at all, so sensor data could not be exported alongside the HealthKit and questionnaire resources Grove already publishes.
⚙️ Release Notes
GroveSensorKitFHIR, which publishes SensorKit recordings as FHIR Observations conforming to the profiles the guides define.📚 Documentation
The new module documents which sensors map to which observation shapes, and how a batch archive is laid out.
✅ Testing
GroveSensorKiton iOS: 3 suites, covering the observation mapping, the batch archive, and the existing SensorKit behaviour.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: