odb: add lint exception to prevent clang-tidy failure on generated code#10767
Merged
maliberty merged 1 commit intoJun 28, 2026
Merged
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces linter suppression comments for readability-simplify-boolean-expr in the less-than operator implementations. It conditionally adds NOLINTBEGIN and NOLINTEND blocks in the Jinja template for classes with a single comparison field, and applies the same suppression to the _dbChip less-than operator. There are no review comments to address, and I have no further feedback to provide.
maliberty
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a dbObject has a single member, the generated
operator<code will trigger a clang-tidy warning:That causes clang-tidy-bazel CI pipeline to fail (e.g., #10758).
With this change, clang-tidy-bazel CI should pass for such a case.
Type of Change
Impact
None.
Verification
./etc/Build.sh).