Skip to content

odb: add lint exception to prevent clang-tidy failure on generated code #10767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maliberty merged 1 commit into from
Jun 28, 2026
+8 −0
Merged

odb: add lint exception to prevent clang-tidy failure on generated code #10767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/odb/src/codeGenerator/templates/impl.cpp.jinja
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,9 @@ namespace odb {

bool _{{klass.name}}::operator<(const _{{klass.name}}& rhs) const
{
{% if klass.less_fields | length == 1 %}
// NOLINTBEGIN(readability-simplify-boolean-expr)
{% endif %}
{% for less in klass.less_fields %}
if ({{less.left}} >= {{less.right}}) {
return false;
Expand All @@ -42,6 +45,9 @@ namespace odb {
//User Code Begin <
//User Code End <
return true;
{% if klass.less_fields | length == 1 %}
// NOLINTEND(readability-simplify-boolean-expr)
{% endif %}
}

_{{klass.name}}::_{{klass.name}}(_dbDatabase* db)
Expand Down
2 changes: 2 additions & 0 deletions src/odb/src/db/dbChip.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,11 +144,13 @@ bool _dbChip::operator==(const _dbChip& rhs) const

bool _dbChip::operator<(const _dbChip& rhs) const
{
// NOLINTBEGIN(readability-simplify-boolean-expr)
if (top_ >= rhs.top_) {
return false;
}

return true;
// NOLINTEND(readability-simplify-boolean-expr)
}

_dbChip::_dbChip(_dbDatabase* db)
Expand Down
Loading