refactor(aria/tabs): clean up tab selection and linking to panels, add direct template ref#33113
Draft
adolgachev wants to merge 3 commits intoangular:mainfrom
Draft
refactor(aria/tabs): clean up tab selection and linking to panels, add direct template ref#33113adolgachev wants to merge 3 commits intoangular:mainfrom
adolgachev wants to merge 3 commits intoangular:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors Tabs pattern to simplify how tabs are associated with their tab panels, as well as other dependent code.
This is a revision of the previous approach which swapped to use contentChildren and template references only. Instead there are 3 commits with layered changes:
However, discussed and currently in agreement that we will not move forward with this PR for the following main reasons: