Migrate the published test base classes off PlexusTestCase - #936
Merged
Conversation
Tests needing an external cvs binary now use assumeTrue and report as skipped; runTest() reported them as passing. Do not restore that to quieten CI.
Member
Author
|
The This comment was created with AI assistance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the JUnit 5 move for the test base classes that wagon publishes:
WagonTestCase,CommandExecutorTestCase,HttpWagonTestCaseandKnownHostsProviderTestCase. These aresrc/main/javain released artifacts, so the change reaches consumers who extend them —which drove three decisions worth a reviewer's attention.
plexus-testingis a compile-scope dependency ofwagon-provider-testandwagon-ssh-common-test.@PlexusTestsits on published classes, so a consumer extendingWagonTestCaseneeds it on their own compile path; test scope would not propagate. Its versionmoves to the root
dependencyManagementalongside the other third-party versions, sincewagon-sshalready declared it and this change would otherwise make three copies.Six members disappeared with
PlexusTestCaseand are replaced rather than dropped, sosubclasses outside this repo keep compiling:
getTestFile,getTestPathandgetBasedirdelegate to
PlexusExtension;getName()is served by aTestInfocallback kept separate fromsetUp()— eight subclasses overridesetUp()and callsuper.setUp(), and widening thatsignature would break every one of them.
runTest()and thetestSkippedflag are gone, replaced byassumeTrue. This changes a CIsignal: on a machine without
cvs, the old mechanism reported those wagon-scm tests aspassing, and they are now reported as skipped (0 → 14 locally). Same tests, honest status.
Checkstyle
FileLengthis suppressed forHttpWagonTestCasevia a newsrc/config/checkstyle-suppressions.xml. One@Testper method took it one line past theinherited 2000-line limit. Neither
@SuppressWarningsnor aCHECKSTYLE_OFFcomment cansuppress it — the reasons are in a comment in that file. Splitting the class is a separate change.
Verified: per-module
<testcase>element counts in the surefire XML are unchanged againstf289bdd5across all eight provider modules (22/23/295/214/42/0/0/295), with no errors orfailures.
This change was created with AI assistance.