Sealed log rebuild must not drop the tail on mid-file CRC - #11
Merged
Conversation
A fully-framed record with a bad CRC in a sealed log is bitrot, not a torn tail. scan_sealed currently copies rebuild_from_records and returns the prefix; the test requires CrcMismatch.
rebuild_from_records used to break and return Ok, dropping every key after the flipped byte. Active-file replay still truncates (that is a torn write).
This was referenced Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A sealed file with a missing footer is scanned record-by-record. The first CRC miss used to
breakand returnOk, so every key after a flipped byte vanished from the index. Two commits: tests that fail on main, then the fix.scan_sealedtreats a fully-framed mid-file CRC miss asCrcMismatch.rebuild_from_recordsuses the same fail-stop. Active-file replay still truncates (that is a torn write).