You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Moves daemon/platform-shared contracts and helper logic out of src/commands so production daemon and platform code no longer imports the CLI command layer. Old command module paths remain as thin re-export shims for compatibility.
Hardens the CI layering guard from warn-only to failure, and updates the fallow health baseline key for the moved interaction-targeting module.
CI review note: the Layering Guard job is red before it reaches the actual import check because ripgrep is not available on the GitHub runner (line 5: rg: command not found). This guard either needs to use a command available in the bare runner checkout, or run after whatever setup installs repo tooling. The failure does not currently prove remaining src/commands imports; it is a guard environment issue.
Review finding: the moved positional helpers are not layer-neutral yet. src/core/interaction-positionals.ts imports ../client-types.ts and ../daemon/selectors.ts, and src/core/wait-positionals.ts imports ../daemon/handlers/parse-utils.ts plus ../daemon/selectors.ts. Since daemon code now imports these core/*positionals.ts helpers, this leaves a daemon -> core -> daemon/client type dependency behind the clean direct-import guard. It also keeps a type path back toward src/commands through client-types.ts.
Can we move the shared selector splitting / timeout parsing pieces to a lower shared module (or keep these helpers in the CLI layer and give the daemon a daemon-local parser) so src/core/** and daemon-shared helpers do not depend on daemon or public client layers?
Preview removed because the pull request was closed.
2026-06-10 12:29 UTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves daemon/platform-shared contracts and helper logic out of src/commands so production daemon and platform code no longer imports the CLI command layer. Old command module paths remain as thin re-export shims for compatibility.
Hardens the CI layering guard from warn-only to failure, and updates the fallow health baseline key for the moved interaction-targeting module.
Closes #726
Touched files: 51. Scope stayed within the requested daemon/platform command-layer import refactor.
Validation
pnpm check:tooling passed: lint, typecheck, MCP metadata check, and build.
rg -n "from '.commands/" src/daemon src/platforms --glob '!/tests/' --glob '!.test.ts' returned no matches.
pnpm check:fallow --base origin/main passed.
pnpm exec vitest run --project unit --no-file-parallelism --maxWorkers 1 passed: 237 files, 2206 tests.
pnpm test:smoke passed with environment-gated loopback cases skipped.
pnpm test:integration:provider passed: 19 files, 38 passed, 10 skipped.
pnpm format and git diff --check passed.