Skip to content

⚡️ Speed up function __dir__ by 58% #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function __dir__ by 58% #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/spdl/io/lib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@


def __dir__() -> list[str]:
return sorted(__all__)
# Avoid sorting on every call by computing once.
# __all__ is static, so it's safe to cache.
# Cache the sorted list on the function object.
if not hasattr(__dir__, "_sorted_all"):
__dir__._sorted_all = sorted(__all__)
return __dir__._sorted_all


def __getattr__(name: str) -> ModuleType:
Expand Down