Fix leader-switch race in v_chunk_id IPC publish within create_shard#445
Closed
JacksonYao287 with Copilot wants to merge 2 commits into
Closed
Fix leader-switch race in v_chunk_id IPC publish within create_shard#445JacksonYao287 with Copilot wants to merge 2 commits into
JacksonYao287 with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code according to review comment
Fix leader-switch race in v_chunk_id IPC publish within create_shard
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
v_chunk_idpublish step increate_shard()usedrun_on_pg_leader(), which has a TOCTOU gap: if the leader changes betweenget_stats()and the lambda, nobody executes it andauxiliary_uint64_idstays atUINT64_MAX, causing the subsequent v_chunk_id equality assertions to flap.Change
run_on_pg_leader()withrun_on_pg_leader_with_retry()for the v_chunk_id IPC publish step, usingauxiliary_uint64_id != UINT64_MAXas thedone_check— consistent with howcreate_sharditself was already fixed.