Skip to content

Fix leader-switch race in v_chunk_id IPC publish within create_shard #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
Closed

Fix leader-switch race in v_chunk_id IPC publish within create_shard #445

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02dc561
Initial plan
Copilot Jun 25, 2026
9567518
Use run_on_pg_leader_with_retry for v_chunk_id IPC publish in create_…
Copilot Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions src/lib/homestore_backend/tests/homeobj_fixture.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,11 +176,14 @@ class HomeObjectFixture : public ::testing::Test {
}

// set v_chunk_id to IPC
run_on_pg_leader(pg_id, [&]() {
auto v_chunkID = _obj_inst->get_shard_v_chunk_id(shard_id);
RELEASE_ASSERT(v_chunkID.has_value(), "failed to get shard v_chunk_id");
g_helper->set_auxiliary_uint64_id(v_chunkID.value());
});
run_on_pg_leader_with_retry(pg_id,
[&] { return g_helper->get_auxiliary_uint64_id() != UINT64_MAX; },
[&]() -> bool {
auto v_chunkID = _obj_inst->get_shard_v_chunk_id(shard_id);
RELEASE_ASSERT(v_chunkID.has_value(), "failed to get shard v_chunk_id");
g_helper->set_auxiliary_uint64_id(v_chunkID.value());
return true;
});

// get v_chunk_id from IPC and compare with local
auto leader_v_chunk_id = g_helper->get_auxiliary_uint64_id();
Expand Down