[keymgr_dpe] Replace keymgr in EG - PR4 BootStageOwnerInt / Top dep. parameter#30618
Open
rroth-lowrisc wants to merge 8 commits into
Open
[keymgr_dpe] Replace keymgr in EG - PR4 BootStageOwnerInt / Top dep. parameter#30618rroth-lowrisc wants to merge 8 commits into
rroth-lowrisc wants to merge 8 commits into
Conversation
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR4_rtl_changes
branch
2 times, most recently
from
July 6, 2026 11:51
ac01bdf to
83a271d
Compare
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR4_rtl_changes
branch
from
July 6, 2026 14:07
83a271d to
17e7709
Compare
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR4_rtl_changes
branch
from
July 6, 2026 15:55
17e7709 to
14b6897
Compare
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR4_rtl_changes
branch
from
July 7, 2026 14:09
14b6897 to
4d3ee59
Compare
gautschimi
reviewed
Jul 13, 2026
gautschimi
left a comment
gautschimi
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this PR. It looks good from my side. Only a few minor comments/questions
| device_id_i, | ||
| lc_keymgr_div_i, | ||
| rom_digests, | ||
| revision_seed}); |
Contributor
There was a problem hiding this comment.
Is there a reason why the order has changed? (position of revision_seed)
Contributor
Author
There was a problem hiding this comment.
Earlgrey and Darjeeling do not support the same ordering of seed material right now. Because keymgr and keymgr_dpe was developed for the corresponding top each, they reflect the ordering too.
In the future this could be changed so that both tops require the same ordering. However it would not change the RTL significantly as the if ... else ... could not be remove (due to the creator_seed).
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR4_rtl_changes
branch
from
July 15, 2026 15:16
4d3ee59 to
c887a6a
Compare
Contributor
Author
|
The last [CI-Blocker] commit is intentional to prevent the CI from running (at least partially) as discussed with @vogelpi . The reason is to avoid unnecessary runtime of the CI. I will remove the commit as soon as I get review from the DV team. |
Split the otp_keymgr_key interface into its respective components. Future version of the keymgr(_dpe) may receive the information from different IP's rather than combined from the otp_ctrl. To avoid a circular dependencies the DevIdWidth instantiated in keymgr_dpe_pkg replaces the otp_ctrl_pkg::DeviceIdWidth. As the keymgr still expects the combined message the earlgrey top manually combines the key material. This fix will be removed when the keymgr is replaced by the keymgr_dpe. Signed-off-by: Raphael Roth <rroth@lowrisc.org>
This commit updates the `otp_ctrl` dv to reflect the new interface between the `keymgr` and the `otp_ctrl`. The secret / seed verification inside the otp_ctrl scoreboard template are no longer dynamically generated. The reason is that the previously shared port signal has been split into its respective components, which does not interacts well with the dynamic generation anymore. However, adding a secret to the otp now results in a port-list change anyways the resulting overhead is deemed acceptable. Signed-off-by: Raphael Roth <rroth@lowrisc.org>
This commit removes all otp_ctrl dependency in the keymgr_dpe dv. This change ensures that the dv architecture accurately reflects the dependency in the RTL implementation. Signed-off-by: Raphael Roth <rroth@lowrisc.org>
This commit improves the block level dv by: - Introducing more verbose messages - Latching the correct DEFAULT_UDS_POLICY - Prevent ambiguous state after the disable operation by restricting any advance call Signed-off-by: Raphael Roth <rroth@lowrisc.org>
The scoreboard loads the UDS directly from the DUT via interface. The problem is the `keymgr_dpe` initializes the slot for the UDS with randomness. The initaly loaded UDS is xored with the randomness already present in the destination slot as countermeasure for SCA. The scoreboard however can currently not recreate this randomness thus the backdoor load. Signed-off-by: Raphael Roth <rroth@lowrisc.org>
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR4_rtl_changes
branch
from
July 20, 2026 08:57
c887a6a to
40b5aa8
Compare
Introduction of the third bootstage defined in the opentitan identities-and-root-keys (https://opentitan.org/book/doc/security/specs/identities_and_root_keys/index.html) strategy. The `creator_seed` is now consumed by BootStageOwnerInt rather than by BootStageCreator. Signed-off-by: Raphael Roth <rroth@lowrisc.org>
This commit allows for a limited parametrization by the top without having a fully templated IP. The top can define the following: - Number of bootstages (either two or three) - Number of ROM digest values - Number of HW slots instanciated (up to 8 slots) The block level dv is extended to test two different configurations, called earlgrey and darjeeling. Signed-off-by: Raphael Roth <rroth@lowrisc.org>
rroth-lowrisc
force-pushed
the
keymgr_dpe_PR4_rtl_changes
branch
from
July 20, 2026 14:33
40b5aa8 to
267b186
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR4 - BootStageOwnerInt / Top dep. parameter
This PR is the fourth in a series which will replace the keymgr with the kemgr_dpe in earlgrey. The replacement was approved by this RFC.
Merge-Dependencies
Relevant Commits
Last two commits
Description
The goal of this PR is twofold:
keymgr_dpeinto earlgrey as approved by the RFC.After this PR is approved, both commits should be squashed together into a single commit.