Ignore blank PO revision dates#1269
Open
ShipItAndPray wants to merge 1 commit intopython-babel:masterfrom
Open
Ignore blank PO revision dates#1269ShipItAndPray wants to merge 1 commit intopython-babel:masterfrom
ShipItAndPray wants to merge 1 commit intopython-babel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PO-Revision-Dateheader values when loading catalog MIME headers.poheader with a blank revision dateCloses #1219.
Validation
master,pofile.read_po()raisesValueError: time data '' does not match format '%Y-%m-%d %H:%M'when the header containsPO-Revision-Date:with an empty value.origin/masterworktree with only the new test applied:python3 -m pytest tests/messages/test_pofile_read.py -k 'blank_revision_date' -q1 failed, 31 deselectedpython3 -m pytest tests/messages/test_pofile_read.py -k 'blank_revision_date' -q1 passed, 31 deselectedrevision_date == 'YEAR-MO-DA HO:MI+ZONE'python3 -m pytest tests/messages/test_catalog.py -k 'datetime_parsing' -q1 passed, 43 deselectedbabel/messages/catalog.pyandtests/messages/test_pofile_read.py.Note: I did not use the full
tests/messages/test_pofile_read.pyfile as a validation gate because this raw source checkout does not have Babel's locale data bundle built, and many unrelated tests in that file fail before reaching this issue's code path.