Skip to content

Ignore blank PO revision dates #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ShipItAndPray wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Ignore blank PO revision dates #1269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion babel/messages/catalog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ def _set_mime_headers(self, headers: Iterable[tuple[str, str]]) -> None:
self.creation_date = _parse_datetime_header(value)
elif name == 'po-revision-date':
# Keep the value if it's not the default one
if 'YEAR' not in value:
if value.strip() and 'YEAR' not in value:
self.revision_date = _parse_datetime_header(value)

mime_headers = property(
Expand Down
10 changes: 10 additions & 0 deletions tests/messages/test_pofile_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,16 @@ def test_header_entry():
assert list(catalog)[0].fuzzy


def test_header_entry_blank_revision_date():
buf = StringIO(r'''
msgid ""
msgstr ""
"PO-Revision-Date: \n"
''')
catalog = pofile.read_po(buf)
assert catalog.revision_date == 'YEAR-MO-DA HO:MI+ZONE'


def test_obsolete_message():
buf = StringIO(r'''# This is an obsolete message
#~ msgid "foo"
Expand Down