Fix Core dSYM Maven URLs in GitHub release notes - #58114
Closed
pistonsky wants to merge 1 commit into
Closed
Conversation
The draft-release template linked the prebuilt React.xcframework tarballs instead of the Core dSYM artifacts because the dSYM- classifier was missing.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
the
Shared with Meta
cipolleschi
approved these changes
Aug 25, 2026
cipolleschi
left a comment
cipolleschi
left a comment
Contributor
There was a problem hiding this comment.
Amazing, thanks for spotting and fixing this!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D117330772. |
|
@cipolleschi merged this pull request in 5d91707. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub release body generated by
createDraftRelease.jslabeled the last section ReactNative Core dSYMs, but the Maven URLs omitted thedSYM-classifier.That made the links download the prebuilt
React.xcframeworktarball (reactnative-core-debug.tar.gz/reactnative-core-release.tar.gz) instead of the actual dSYMs (reactnative-core-dSYM-debug.tar.gz/reactnative-core-dSYM-release.tar.gz). Hermes and ReactNativeDependencies links already includedSYM-; Core did not.This matches the classifier used when publishing Core dSYMs and the URL
rncore.rbbuilds whenRCT_SYMBOLICATE_PREBUILT_FRAMEWORKS=1.Companion docs fix: reactwg/react-native-releases#1394
Changelog:
[INTERNAL][FIXED] - Point GitHub release Core dSYM links at the dSYM Maven artifacts instead of the framework tarballs
Test Plan
.github/workflow-scripts/__tests__/createDraftRelease-test.jsto match the corrected URLs.yarn installin this monorepo rewriteshermes-compiler/yarn.lockvia the preinstall hook.dSYM-classifier already used for ReactNativeDependencies in this template, and for Core dSYMs inpackages/react-native/scripts/cocoapods/rncore.rb(stable_tarball_url(..., dsyms = true)).