Fix Core dSYM Maven URLs in the release notes template - #1394
Open
pistonsky wants to merge 1 commit into
Open
Conversation
The GitHub release body template linked the prebuilt React.xcframework tarballs instead of the Core dSYM artifacts because the dSYM- classifier was missing.
meta-codesync Bot
pushed a commit
to react/react-native
that referenced
this pull request
Aug 25, 2026
Summary: The GitHub release body generated by `createDraftRelease.js` labeled the last section **ReactNative Core dSYMs**, but the Maven URLs omitted the `dSYM-` classifier. That made the links download the prebuilt `React.xcframework` tarball (`reactnative-core-debug.tar.gz` / `reactnative-core-release.tar.gz`) instead of the actual dSYMs (`reactnative-core-dSYM-debug.tar.gz` / `reactnative-core-dSYM-release.tar.gz`). Hermes and ReactNativeDependencies links already include `dSYM-`; Core did not. This matches the classifier used when publishing Core dSYMs and the URL `rncore.rb` builds when `RCT_SYMBOLICATE_PREBUILT_FRAMEWORKS=1`. Companion docs fix: reactwg/react-native-releases#1394 ## Changelog: [INTERNAL][FIXED] - Point GitHub release Core dSYM links at the dSYM Maven artifacts instead of the framework tarballs Pull Request resolved: #58114 Test Plan: - Updated the expected strings in `.github/workflow-scripts/__tests__/createDraftRelease-test.js` to match the corrected URLs. - Did not run Jest locally: a full `yarn install` in this monorepo rewrites `hermes-compiler` / `yarn.lock` via the preinstall hook. - Confirmed the new URLs follow the same `dSYM-` classifier already used for ReactNativeDependencies in this template, and for Core dSYMs in `packages/react-native/scripts/cocoapods/rncore.rb` (`stable_tarball_url(..., dsyms = true)`). Reviewed By: GijsWeterings Differential Revision: D117330772 Pulled By: cipolleschi fbshipit-source-id: 761f4b821a05f078ea9d1a9cb1882edca822a834
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GitHub release body template in
docs/guide-release-process.mdlabeled the last section ReactNative Core dSYMs, but the Maven URLs omitted thedSYM-classifier.That made the links download the prebuilt
React.xcframeworktarball (reactnative-core-debug.tar.gz/reactnative-core-release.tar.gz) instead of the actual dSYMs (reactnative-core-dSYM-debug.tar.gz/reactnative-core-dSYM-release.tar.gz).Step 6 already
curls the correctreactnative-core-dSYM-*.tar.gzartifacts. This change makes the manual release-notes template match those URLs, and match Hermes / ReactNativeDependencies which already includedSYM-.Companion generator fix: react/react-native#58114
Test Plan
ReactNativeCoreUtils.stable_tarball_url(..., dsyms = true)in react-native (reactnative-core-dSYM-<build_type>.tar.gz).