Fix Debian packaging by DDvO · Pull Request #74 · siemens/libsecutils

DDvO · 2026-05-20T17:09:25Z

This is an enhanced, squashed, and rebased version of Feat/prepare for cmake debian build #68.

It meanwhile also contains a commit fixing compatibility, which introduced the bool type.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 9 comments.

gylstorffq · 2026-06-10T09:54:17Z

                ifeq ($(OS),Linux)
 	            ifeq ($(shell echo $(OPENSSL_DIR) | grep -E '^/(home|Users)'),)
-                        override OPENSSL_LIB = $(wildcard /lib/*linux-gnu*)
+                        override OPENSSL_LIB = $(wildcard /lib/$(shell uname -i)-linux-*)


This fix would be necessary for the Makefile_v1 build in debian.

I've taken this over.

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (2)

debian/rules:46

libsecutils-bin is defined in debian/control, but the rules file does not enable the CMake option/env var that actually builds icvutil (SECURITY_UTILITIES_USE_ICV / SECUTILS_USE_ICV). The current workaround (touch icvutil) risks packaging an empty placeholder into /usr/bin. Prefer enabling the feature for the Debian build (e.g. pass -DSECURITY_UTILITIES_USE_ICV=ON or export SECUTILS_USE_ICV=1) or make the -bin package conditional instead of creating a dummy file.

	dh_auto_build
	dh_auto_build -- doc
	 #	      dh_auto_install --destdir=$(CURDIR)/debian/tmp

override_dh_auto_install:
	touch icvutil # workaround in case SECUTILS_USE_ICV is unset
	dh_auto_install --destdir debian/tmp # -- -f Makefile_v1

CMakeLists.txt:431

In the CPack component loop, COMPONENT_DOC_SUBDIR is set to an empty string and then the same doc files (libsecutils.svg, and on Linux also debian/copyright + changelog.gz) are installed for every component to the same ${CMAKE_INSTALL_DOCDIR} path. This will cause the generated component DEBs (e.g. runtime and -dev) to contain overlapping file paths, which typically results in dpkg file conflicts when installing multiple packages. Consider restoring per-component doc destinations (e.g. include the ${suffix} in the path) or installing shared doc files into only one component/package.

    set(COMPONENT_DOC_SUBDIR "") # "/${PROJECT_NAME}${suffix}"

    if(suffix STREQUAL "-dev")
      install(DIRECTORY ${PROJECT_BINARY_DIR}/doc/html
        OPTIONAL # TODO add build for doc/
        DESTINATION "${CMAKE_INSTALL_DOCDIR}${COMPONENT_DOC_SUBDIR}"
        COMPONENT security-utilities_library_Development
      )
    endif()
    install(FILES
      "${CMAKE_CURRENT_SOURCE_DIR}/libsecutils.svg"
      DESTINATION "${CMAKE_INSTALL_DOCDIR}${COMPONENT_DOC_SUBDIR}"
      COMPONENT ${component}
    )
    if(CMAKE_SYSTEM_NAME MATCHES "Linux")
      install(FILES
        "${CMAKE_CURRENT_SOURCE_DIR}/debian/copyright"
        "${CMAKE_CURRENT_BINARY_DIR}/changelog.gz"
        DESTINATION "${CMAKE_INSTALL_DOCDIR}${COMPONENT_DOC_SUBDIR}"
        COMPONENT ${component}

DDvO · 2026-05-22T10:02:04Z

@gylstorffq, does this look good to you?
For some reason, cannot add you as usual to the list of requested reviewers.

DDvO · 2026-06-09T07:31:50Z

Ping @gylstorffq - did you see my follow-up commits?
Please let me know if this still accomplishes what you were aiming at.

gylstorffq · 2026-06-09T07:41:24Z

I didn't have time to check it - will try to do it in this week.

gylstorffq

I did a test build with

sbuild -d trixie --profile nocheck --no-clean-source .

I have the following lintian messages during build for trixie.
W: libsecutils-bin: executable-not-elf-or-script [usr/bin/icvutil]
W: libsecutils: lacks-unversioned-link-to-shared-library example: usr/lib/x86_64-linux-gnu/libsecutils.so [usr/lib/x86_64-linux-gnu/libsecutils.so.2.2.0]
W: libsecutils: link-to-shared-library-in-wrong-package usr/lib/x86_64-linux-gnu/libsecutils.so.2.2.0 [usr/lib/x86_64-linux-gnu/libsecutils.so]
W: libsecutils-bin: no-manual-page [usr/bin/icvutil]
W: libsecutils source: no-versioned-debhelper-prerequisite 10
W: libsecutils: package-name-doesnt-match-sonames libsecutils2

Also this will not build with gcc-15 as default version c standard changes to c23, which defines bool.

gylstorffq · 2026-06-10T09:47:18Z

 Priority: optional
 Maintainer: Benjamin Schilling <Schilling.Benjamin@siemens.com>
-Uploader: David von Oheimb <David.von.Oheimb@siemens.com>
 Build-Depends: libssl-dev, debhelper (>= 9), devscripts


cmake is missing as a build depends

gylstorffq · 2026-06-10T09:48:33Z


 Package: libsecutils-dev
-Depends: libsecutils (>= 2.2), ${misc:Depends}
+Depends: ${misc:Depends}, ${shlibs:Depends}, libssl-dev


This would be more correct:
Depends: libsecutils (= ${binary:Version}), ${misc:Depends}, libssl-dev
Suggests: libuta-dev

gylstorffq · 2026-06-10T09:54:17Z

                ifeq ($(OS),Linux)
 	            ifeq ($(shell echo $(OPENSSL_DIR) | grep -E '^/(home|Users)'),)
-                        override OPENSSL_LIB = $(wildcard /lib/*linux-gnu*)
+                        override OPENSSL_LIB = $(wildcard /lib/$(shell uname -i)-linux-*)


This fix would be necessary for the Makefile_v1 build in debian.

gylstorffq · 2026-06-10T09:55:16Z

-CC=$(DEB_HOST_GNU_TYPE)-gcc
-CXX=$(DEB_HOST_GNU_TYPE)-g++
-AR=$(DEB_HOST_GNU_TYPE)-ar
+# DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH)


You should remove that commented code.

I've moved this close to the place where (also commented out meanwhile) it was used before.

gylstorffq · 2026-06-10T10:00:22Z

 Section: devel
-Architecture: all
+Architecture: any
 Multi-Arch: foreign


Multi-Arch: foreign will lead to a lintian error. I would remove it.

This adds the package configuration information, which allows to use the cmake files of the library in distributions like Debian.

This is necessary to build the system

This allows to disable the cpack build and other parts which are incompatible with building a Debian package.

…IB on Linux

…' as keywords

…available without SECUTILS_USE_ICV

…tallation

…sions

…d ldconfig calls

…ription also with debian/control

…DEVELOPMENT_PACKAGE_ARCHITECTURE "all"

DDvO · 2026-06-11T20:34:07Z

Thanks @gylstorffq for your comments.
I meanwhile handled all of them
and finally also managed to get rid of all lintian warning, using massive support by Copilot.

…E_INSTALL_LIBDIR

…, following Copilot suggestion

DDvO added bug Something isn't working enhancement New feature or request labels May 20, 2026

DDvO force-pushed the fix-Debian-packaging branch from 37cbf6e to 286eb8c Compare May 20, 2026 17:15

DDvO requested a review from Copilot May 20, 2026 17:15

Copilot started reviewing on behalf of DDvO May 20, 2026 17:22 View session

Copilot AI reviewed May 20, 2026

DDvO requested a review from Copilot May 20, 2026 17:50

Copilot started reviewing on behalf of DDvO May 20, 2026 17:51 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

DDvO force-pushed the fix-Debian-packaging branch from 286eb8c to 16d3e88 Compare May 22, 2026 09:23

DDvO requested a review from Copilot May 22, 2026 09:25

Copilot started reviewing on behalf of DDvO May 22, 2026 09:26 View session

Copilot AI reviewed May 22, 2026

View reviewed changes

Comment thread src/libsecutils/include/secutils/CMakeLists.txt

Comment thread src/CMakeLists.txt Outdated

Comment thread debian/libsecutils-dev.install

Comment thread debian/rules Outdated

Comment thread CMakeLists.txt Outdated

DDvO force-pushed the fix-Debian-packaging branch 2 times, most recently from 78db8d4 to 0701d22 Compare May 22, 2026 09:55

DDvO requested a review from rajeev-0 May 22, 2026 10:00

DDvO mentioned this pull request May 22, 2026

Feat/prepare for cmake debian build #68

Open

gylstorffq reviewed Jun 10, 2026

View reviewed changes

DDvO force-pushed the fix-Debian-packaging branch from 9f0cd8f to 04dbaaf Compare June 11, 2026 07:28

gylstorffq and others added 4 commits June 11, 2026 10:00

chore: add pkgconfig file

2df7519

This adds the package configuration information, which allows to use the cmake files of the library in distributions like Debian.

chore: generate secutils_static_config.h in cmake

677cc75

This is necessary to build the system

chore: add DEBIAN_BUILD flag

3438a45

This allows to disable the cpack build and other parts which are incompatible with building a Debian package.

Makefile_v1: improve directory pattern for auto-determining OPENSSL_L…

719fa4d

…IB on Linux

DDvO force-pushed the fix-Debian-packaging branch from 04dbaaf to 435732a Compare June 11, 2026 16:17

debian/control: fix libsecutils-dev Depends and Architecture

7b18209

DDvO force-pushed the fix-Debian-packaging branch from 435732a to eca141a Compare June 11, 2026 16:25

DDvO and others added 13 commits June 11, 2026 18:47

libsecutils.install: fix reference to libsecutils.so*

096d679

debian/rule: re-add workaround on presence of 'icvutil'

72aa48c

CMakeLists.txt,debian/rules: trying to fix inclusion of doc/html

a7c69a1

basic.h: fix compatibility with C23, which provides 'true' and 'false…

117fcab

…' as keywords

debian/rules: add placeholder 'icvutil' script in case binary is not …

e680019

…available without SECUTILS_USE_ICV

man/icvutil.1,debian/rules: add icvutil.1 man page and its Debian ins…

93669f2

…tallation

debian/: add library major version to its name (libsecutils2)

352afc5

CMakeLists.txt: Ensure installed directories get standard 0755 permis…

d01b6e3

…sions

CMakeLists.txt: use share/doc instead of CMAKE_INSTALL_DOCDIR

7d207ed

CMakeLists.txt: fix COMPONENT_DOC_SUBDIR

ecc74e1

CMakeLists.txt: Custom postinst/postrm suppress CPack's auto-generate…

73a112f

…d ldconfig calls

CMakeLists.txt: shorten CPACK_PACKAGE_DESCRIPTION_SUMMARY; aling desc…

f6614cc

…ription also with debian/control

CMakeLists.txt: remove wrong CPACK_DEBIAN_SECURITY-UTILITIES_LIBRARY_…

9384241

…DEVELOPMENT_PACKAGE_ARCHITECTURE "all"

DDvO force-pushed the fix-Debian-packaging branch 2 times, most recently from 6450947 to 6dc2a66 Compare June 11, 2026 20:01

CMakeLists.txt: force multiarch

2571fb1

DDvO force-pushed the fix-Debian-packaging branch from 6dc2a66 to 2571fb1 Compare June 11, 2026 20:04

DDvO requested a review from gylstorffq June 11, 2026 20:05

Copilot started work on behalf of DDvO June 11, 2026 20:21 View session

Copilot finished work on behalf of DDvO June 11, 2026 20:27

DDvO force-pushed the fix-Debian-packaging branch from ec028ad to d68de52 Compare June 11, 2026 20:30

DDvO requested review from benjamin-schilling and gylstorffq and removed request for gylstorffq June 12, 2026 10:56

DDvO mentioned this pull request Jun 15, 2026

Fix failing GitHub Actions "cmake" job on Windows siemens/gencmpclient#123

Open

DDvO added 3 commits June 15, 2026 17:49

CMakeLists.txt,build.yml: improve uninstall and related check on CMAK…

cb7ea40

…E_INSTALL_LIBDIR

Makefile_v1: make fallback determination of OPENSSL_LIB more reliable…

2d8a1f6

…, following Copilot suggestion

CMakeLists.txt: fix use of CMAKE_INSTALL_FULL_LIBDIR, which is absolute

e231405

DDvO force-pushed the fix-Debian-packaging branch from 85aedc5 to e231405 Compare June 15, 2026 15:50

Conversation

DDvO commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gylstorffq Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

DDvO Jun 15, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DDvO commented May 22, 2026

Uh oh!

DDvO commented Jun 9, 2026

Uh oh!

gylstorffq commented Jun 9, 2026

Uh oh!

gylstorffq left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gylstorffq Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

gylstorffq Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

gylstorffq Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

gylstorffq Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

DDvO Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

gylstorffq Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DDvO commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DDvO commented May 20, 2026 •

edited

Loading

gylstorffq left a comment •

edited

Loading

gylstorffq Jun 10, 2026 •

edited

Loading