Skip to content

refactor: align expense preview card metadata line with mobile row styling - #96942

Merged
JS00001 merged 9 commits into
Expensify:mainfrom
Krishna2323:fix/96475-expense-preview-row-styling
Aug 6, 2026
Merged

refactor: align expense preview card metadata line with mobile row styling#96942
JS00001 merged 9 commits into
Expensify:mainfrom
Krishna2323:fix/96475-expense-preview-row-styling

Conversation

@Krishna2323

@Krishna2323 Krishna2323 commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Fixed Issues

$ #96475
PROPOSAL:

Tests

  1. Open Spend and note a mobile expense row: Merchant | Amount, then Date • Category | Cash/Card.
  2. Open the same expense’s preview card in chat/report preview — layout and muted second-line styling should match.
  3. Check with and without a category (no empty when category is missing).
  4. Check Cash and Card types, plus a bill-split preview (avatars / your split still work).
  5. Spot-check pending, deleted (strikethrough), and RBR cases still look correct.
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4

…yling

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@Expensify/design one quick question.

Previously the small line showed the report status alongside the date and type, e.g. Feb 6 • Cash • Approved (also for Review required, Settled, Canceled, and Hold).

The new mocks only show Date • Category on the left and Cash/Card on the right, with no status. Should we:

  1. Drop the status from this line entirely (exactly matching the mocks), or
  2. Keep it appended after the category, e.g. Feb 6 • Meals & Entertainment • Review required?

I've gone with option 2 for now so we don't lose that info, but happy to switch to option 1 if that's what you'd prefer.

image

…line

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
.../MoneyRequestReportPreview/ReportPreviewHeader.tsx 100.00% <100.00%> (ø)
...m/TransactionPreview/TransactionPreviewContent.tsx 82.45% <93.33%> (+5.11%) ⬆️
src/libs/TransactionPreviewUtils.ts 85.99% <92.30%> (+0.14%) ⬆️
... and 216 files with indirect coverage changes

@Krishna2323
Krishna2323 marked this pull request as ready for review July 29, 2026 14:55
@Krishna2323
Krishna2323 requested review from a team as code owners July 29, 2026 14:55
@melvin-bot
melvin-bot Bot requested review from situchan and trjExpensify and removed request for a team July 29, 2026 14:55
@melvin-bot

melvin-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

@situchan Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team July 29, 2026 14:55

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9be8da5bd5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@shawnborton

Copy link
Copy Markdown
Contributor

Hmm any strong feelings there @trjExpensify @JmillsExpensify ? Maybe it makes sense to put it before the category.

I also think Approved or Review required feels kinda redundant so maybe we don't need to show those any more? You have the report status and the violation row for those.

@trjExpensify

Copy link
Copy Markdown
Contributor

I also think Approved or Review required feels kinda redundant so maybe we don't need to show those any more? You have the report status and the violation row for those.

Yeah, I agree they seem redundant now.

Settled, Canceled,

What are these two though?

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@trjExpensify @shawnborton By "settled," I meant paid, and by "canceled," I meant canceled 😅. I wasn't able to repro the canceled state myself, but from the code logic it's shown when the IOU/expense report has isCancelledIOU: true — that gets set after Cancel payment (not when deleting an expense).

So on the preview supporting line today:

  • Paid → shows "Paid" / "Done" text (iou.settledExpensify / common.done)
  • Canceled → shows "Canceled" text (iou.canceled) when payment was canceled

Paid does show as a report-level status badge; canceled does not — it’s only the supporting-line text. Should we keep Paid / Canceled on that line, or drop them too (same as Approved / Review required)?

image image

@shawnborton

Copy link
Copy Markdown
Contributor

I would say it makes sense to drop Paid (get rid of it, we already have it as a badge). But we can keep Cancelled since it doesn't show up anywhere else. That being said, I almost wonder if this makes more sense at the very top like [Paid] Canceled • 1 Expense? Do you know if these statuses tied to the expense itself or mostly tied to the overall expense report?

@Krishna2323

Copy link
Copy Markdown
Contributor Author

I almost wonder if this makes more sense at the very top like [Paid] Canceled • 1 Expense?

Both are tied to the expense report, not the individual expense.

  • Paid is based on isSettled(iouReport).
  • Canceled comes from iouReport.isCancelledIOU.

We already show the Paid badge at the report level, but Canceled isn't shown there yet.

Should I go ahead and update it as suggested?

@shawnborton

Copy link
Copy Markdown
Contributor

Nice, I would say yes - update it so that the extra status is applied at the top expense report level and not the expense preview level. Tom can confirm when he is back too.

@trjExpensify

Copy link
Copy Markdown
Contributor

Yeah, I tend to agree that's better placement for a report level action like cancelling the payment. I take it it goes away if you pay it again? 👍

@Krishna2323

Copy link
Copy Markdown
Contributor Author
  • Cancelled state
image

I take it it goes away if you pay it again? 👍

Yes, not optimistically—it gets cleared once the API call succeeds.

Monosnap.screencast.2026-08-04.22-58-01.mp4

…rting line

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@Krishna2323

Copy link
Copy Markdown
Contributor Author

@codex review

@shawnborton

Copy link
Copy Markdown
Contributor

Looks good to me 👍

@Krishna2323

Copy link
Copy Markdown
Contributor Author

Bug: Canceled status is removed after refresh

Also reproducible on staging:

Monosnap.screencast.2026-08-06.03-25-26.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>
@melvin-bot
melvin-bot Bot requested a review from JS00001 August 6, 2026 02:57
@JS00001
JS00001 merged commit 84af734 into Expensify:main Aug 6, 2026
38 of 40 checks passed
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

OSBotify commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #98206 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.52-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review — one doc update needed.

This PR restyled the expense preview card's metadata line to match the new mobile row styling and, as part of that, removed the tag from the preview card (the second line now shows date and category, with the type — Cash/Card/Split — shown separately).

The Spend Page help article still listed tag as part of the expense preview details, so I've opened a draft PR to correct it:

No other docs/articles content references the preview card layout, and the rest of this PR (canceled-status handling, amount/type placement, split avatars) is internal styling/logic that isn't described in the help site, so nothing else needs updating.

@Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

@jponikarchuk

Copy link
Copy Markdown

@Krishna2323 @shawnborton @trjExpensify @situchan Could you please check if it's an expected behaviour or WAD?

Report - "This expense was put on hold" is not completelly visible on report preview.

Prerequisite: Account has at least one workspace.

  1. Open the staging.new.expensify.com website.
  2. Open any workspace chat.
  3. Create a manual expense.
  4. Right click on preview > "Hold"
  5. Enter any reason and hold the expense,
  6. Note that "This expense was put on hold" message on report preview, is displayed on the same line as date and category and is not completelly visible.
Bug7230934_1786449658488.Hold_Cut.mp4

@shawnborton

Copy link
Copy Markdown
Contributor

@Krishna2323 I would expect "This expense was put on hold" to be the message shown in the red "review required" area.

@jponikarchuk

Copy link
Copy Markdown

Thanks a lot @shawnborton
I'll export this

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #98329 was identified to be related to this PR.

JS00001 added a commit that referenced this pull request Aug 11, 2026
cretadn22 pushed a commit to cretadn22/App that referenced this pull request Aug 11, 2026
JS00001 added a commit that referenced this pull request Aug 11, 2026
[cp staging] Revert #96942

(cherry picked from commit 6f63c63)

(cherry-picked to staging by Julesssss)
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.53-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants