refactor: align expense preview card metadata line with mobile row styling - #96942
Conversation
…yling Signed-off-by: krishna2323 <belivethatkg@gmail.com>
…line Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9be8da5bd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hmm any strong feelings there @trjExpensify @JmillsExpensify ? Maybe it makes sense to put it before the category. I also think Approved or Review required feels kinda redundant so maybe we don't need to show those any more? You have the report status and the violation row for those. |
Yeah, I agree they seem redundant now.
What are these two though? |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@trjExpensify @shawnborton By "settled," I meant paid, and by "canceled," I meant canceled 😅. I wasn't able to repro the canceled state myself, but from the code logic it's shown when the IOU/expense report has So on the preview supporting line today:
Paid does show as a report-level status badge; canceled does not — it’s only the supporting-line text. Should we keep Paid / Canceled on that line, or drop them too (same as Approved / Review required)?
|
|
I would say it makes sense to drop Paid (get rid of it, we already have it as a badge). But we can keep Cancelled since it doesn't show up anywhere else. That being said, I almost wonder if this makes more sense at the very top like |
Both are tied to the expense report, not the individual expense.
We already show the Paid badge at the report level, but Canceled isn't shown there yet. Should I go ahead and update it as suggested? |
|
Nice, I would say yes - update it so that the extra status is applied at the top expense report level and not the expense preview level. Tom can confirm when he is back too. |
|
Yeah, I tend to agree that's better placement for a report level action like cancelling the payment. I take it it goes away if you pay it again? 👍 |
…rting line Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@codex review |
|
Looks good to me 👍 |
Also reproducible on staging: Monosnap.screencast.2026-08-06.03-25-26.mp4 |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
Deploy Blocker #98206 was identified to be related to this PR. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.52-0 🚀
|
|
🤖 Help site review — one doc update needed. This PR restyled the expense preview card's metadata line to match the new mobile row styling and, as part of that, removed the tag from the preview card (the second line now shows date and category, with the type — Cash/Card/Split — shown separately). The Spend Page help article still listed tag as part of the expense preview details, so I've opened a draft PR to correct it:
No other @Krishna2323, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
@Krishna2323 @shawnborton @trjExpensify @situchan Could you please check if it's an expected behaviour or WAD? Report - "This expense was put on hold" is not completelly visible on report preview.Prerequisite: Account has at least one workspace.
Bug7230934_1786449658488.Hold_Cut.mp4 |
|
@Krishna2323 I would expect "This expense was put on hold" to be the message shown in the red "review required" area. |
|
Thanks a lot @shawnborton |
|
Deploy Blocker #98329 was identified to be related to this PR. |
…expense-preview-row-styling
|
🚀 Deployed to production by https://github.com/roryabraham in version: 9.4.52-11 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.53-0 🚀
|




Explanation of Change
Fixed Issues
$ #96475
PROPOSAL:
Tests
•when category is missing).Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4