Make the Questionnaire Swift-First and Conformant to Its Published Profiles

[PSchmiedmayer]

♻️ Current situation & Problem

Grove questionnaires could only be authored as FHIR JSON, and what the converter emitted did not match the profiles grove-fhir publishes.

This change covers questionnaire authoring, the questionnaire UI, and the questionnaire ↔ FHIR bridge, together with the FHIRPath evaluator the expression features rest on.

⚙️ Release Notes

• A typed Swift DSL is now the primary way to declare a questionnaire. A declared question doubles as a typed handle, so the same value is used for the body, for typed answers, and for conditions.

let sleep = ChoiceQuestion("sleep", "How well did you sleep?", options: Rating.self)

Questionnaire(url: url, title: "Daily Check-In") {
    Section("s1", title: "Sleep") {
        sleep
        NumberQuestion("hours", "Hours slept").range(0...24)
            .enabledWhen(sleep.answered)
    }
}

let rating = responses[sleep]        // Rating?

• @Instrument declares a reusable instrument and validates its references, link IDs, and score expressions at compile time.
• Questionnaires can carry score expressions and evaluate them themselves.
• Bidirectional FHIR Questionnaire conversion and conformant QuestionnaireResponse export: emitted resources declare the profiles they claim, keep their lifecycle across a round trip, and carry conformant quantity units and answer-option codings.
• A FHIRPath evaluator supporting the subset SDC questionnaires need, driving enableWhenExpression, calculatedExpression, variable, and targetConstraint. Its three-valued result is modelled explicitly rather than as Bool?.
• The questionnaire UI is rebuilt around one card per question, with a reworked navigation and completion flow, group captions, and per-page item numbering.
• Draft responses survive a round trip, including answers nested under a choice option.

📚 Documentation

AuthoringQuestionnaires.md and QuestionKinds.md cover the DSL, the modifiers, scoring, and the extension point for custom question kinds. The DSL's compilation hooks are hidden from DocC and carry inline notes explaining why Swift forces them public.

✅ Testing

• GroveQuestionnaire on macOS: 19 suites, including FHIR conformance, conversion, expression, scoring, prepopulation, draft-lifecycle, and macro-expansion coverage.
• FHIRModelsExtensions on macOS: 11 suites, including the FHIRPath parser and evaluator.
• swiftlint --strict is clean with no baseline file and no new rule suppressions beyond the DSL's underscored protocol requirements, each annotated at its declaration.

Code of Conduct & Contributing Guidelines

By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

• I agree to follow the Code of Conduct and Contributing Guidelines.

[Copilot]

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

[coderabbitai]

Important

• 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 60f19bf5-854a-4e34-a40c-e6c2e99d2dff

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[PSchmiedmayer]

Contract-coordination note for this stack: ResearchStudyAttribution is a real cross-domain My Heart Counts requirement, not Questionnaire-specific cleanup. Please preserve the implementation and tests, but move/extract ownership to the shared FHIR acquisition/research-context layer when the stack is revised for grove-fhir #6.

The accepted model still needs a focused standards decision covering workflow-researchStudy, ResearchStudy/ResearchSubject, consent, exact protocol or study-definition revision, and transformation Provenance. The current custom study-revision extension may be replaced, but it should not disappear until a My Heart Counts legacy fixture and the new writer/reader migration are tested. Questionnaire package/profile work remains coordinated through grove-fhir #7 and Grove #62.

This is a future restacking requirement, not approval to merge this PR and not a runner change.