Bring HealthKit's FHIR Output in Line With the Published Profiles - #60
Bring HealthKit's FHIR Output in Line With the Published Profiles#60PSchmiedmayer wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Contract target for the next revision: preserve this PR as the Grove Swift/HealthKit reference implementation for grove-fhir #6, but move the shared subject/source-identity/sensor/gateway/recording/study/provenance rules into a platform-neutral layer before the final package switch. Health Connect is not being discarded because it is absent from Swift. Its Android implementation destination is MyHeartCounts-Android #31, which will target the same Mobile profiles and provide independent fixtures. Likewise, My Heart Counts clinical passthrough, study attribution, and metadata/privacy needs require explicit destinations rather than blanket deletion from the prototype inventory. When #6 settles the package, rebase this PR on those accepted profiles and retain its deterministic HealthKit mappings/tests as evidence for grove-fhir #8. This note does not authorize merging the PR or changing its runners. |
5e5bcfa to
8c4acdd
Compare
fb78db4 to
899879e
Compare
8c4acdd to
95f9ca1
Compare
899879e to
c3a9543
Compare
95f9ca1 to
b74abb1
Compare
c3a9543 to
1bbf763
Compare
1bbf763 to
3bc7487
Compare
3bc7487 to
78957a7
Compare
|
Superseded by #67, which rewrites this work on the catalog-driven converter and the published v0.2 profiles. Sensor coverage, stable output identity, metadata-key handling and device provenance all carry over; the vocabulary is now sourced from the grove-fhir catalogs with a CI drift check rather than a golden dump in this repo. |
♻️ Current situation & Problem
HealthKit samples converted to FHIR did not match the profiles
grove-fhirpublishes: metadata and provenance used spellings the guides do not define, and a release once shipped observations that declared a profile they violated.⚙️ Release Notes
grove-platform-metadata, with the metadata key carried in akeysub-extension rather than nested in the URL, and source records togrove-source-record-id.grove-fhirare generated from the values Grove actually emits instead of being re-derived.📚 Documentation
The conversion helpers document which spellings are written versus only read, and
Migrating to Grove.mdreflects the new metadata shape.✅ Testing
GroveHealthKitFHIRon macOS: 16 suites covering category, quantity, correlation, workout, ECG, state-of-mind, metadata, time zone, and superseded-spelling behaviour, plus the macro expansions.Scripts/validate-fhir-conformance.shputs through the HL7 validator against both published guide packages.Code of Conduct & Contributing Guidelines
By creating and submitting this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: